GNOME Bugzilla – Bug 766603
Location services won't work with Flatpak
Last modified: 2016-07-25 11:51:29 UTC
In the flatpak 0.6.0 release announcement: > * The bus name and interface name for the permission > store is changed, it was in org.freedesktop.XdgApp, but is > now in org.freedesktop.impl.portal.DesktopPortal.
(In reply to Bastien Nocera from comment #0) > In the flatpak 0.6.0 release announcement: > > * The bus name and interface name for the permission > > store is changed, it was in org.freedesktop.XdgApp, but is > > now in org.freedesktop.impl.portal.DesktopPortal. Great! This breaks gnome-shell too. :(
It breaks softly though. As these dependencies were runtime optional, right? I mean, we didn't have hard deps on xdg-app, did we? Also, technically, this is a better name, as its independent of flatpak (could be broken out and shared if needed).
(In reply to Zeeshan Ali (Khattak) from comment #1) > Great! This breaks gnome-shell too. :( I filed bug 766598 earlier.
(In reply to Alexander Larsson from comment #2) > It breaks softly though. As these dependencies were runtime optional, right? > I mean, we didn't have hard deps on xdg-app, did we? > > Also, technically, this is a better name, as its independent of flatpak > (could be broken out and shared if needed). Well, it won't break in the sense that control-center and shell won't build or stop working but once users start to save their location preferences, we'll all of a sudden not be able to remember them or save them, until we port these components. It's D-Bus though, so we can still remain backwards compatible when we port. It's only the API that's changed right? The store itself remains intact when upgrading from xdg-app to flatpak?
Yes, the database will be migrated.
(In reply to Alexander Larsson from comment #5) > Yes, the database will be migrated. In that case, simply updating the bus/interface names looks good enough to me for 3.21.x - for users following the development cycle there'll be a small window where stuff can break if gs/gcc/flatpak aren't updated in lock-step, but that should sort itself out way before 3.22. Another question would be whether we expect (stable) distros to ship an xdg-app => flatpak update - in that case, do we need to come up with something fancier for 3.20?
We will be updating f23 to flatpak, but I don't think it matters much at this point. Use of flatpak/xdg-app on that will be limited in scope.
I did mean "distros that use 3.20", so f24. Unless we update gcc/gs there, per-application access to location services will be broken, though I think I agree with you that it doesn't matter too much - it only really affects users that used a pre-release version, installed xdg-app *and* rejected access for some app ... (Still probably a good idea to apply the rename to the stable branch, but without keeping compatibility with the old name ...)
Created attachment 331439 [details] [review] privacy: Update for PermissionStore DBus API changes As xdg-app has been renamed to Flatpak, the permission store's bus name and interface name have been changes as well.
Attachment 331439 [details] pushed as 790b2c3 - privacy: Update for PermissionStore DBus API changes
(In reply to Zeeshan Ali (Khattak) from comment #10) > Attachment 331439 [details] pushed as 790b2c3 - privacy: Update for > PermissionStore DBus API changes How about 3.20?