After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766560 - [review] drop nm-connection-provider [th/drop-connection-provider-bgo766560]
[review] drop nm-connection-provider [th/drop-connection-provider-bgo766560]
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-05-17 10:44 UTC by Thomas Haller
Modified: 2016-05-24 10:47 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Thomas Haller 2016-05-17 10:44:52 UTC
Please review.



Quote:



    core: drop NMConnectionProvider and use NMSettings directly
    
    This is not C# but glib. Using interfaces is so cumbersome, that they
    don't simplify code but make it more complicated.
    
    E.g. following signals and its subscribers is complicated enough. It gets
    more complicated by having NM_SETTINGS_SIGNAL_CONNECTION_ADDED and
    NM_CP_SIGNAL_CONNECTION_ADDED. Of course, your favorite IDE has no idea
    about glib interfaces, so figuring out who calls who gets more
    complicated.
    
    This undoes commit 4fe48b1273cff8dde3688a1dc4b7bcbf0a9e16f4. Originally,
    NMConnectionProvider had only one function get_best_connection(). But it
    kept growing and more functions were added.
    
    If we want to ~hide~ certain part of the NMSettings API, we should move them
    to a separate header which gives internal access.
Comment 1 Beniamino Galvani 2016-05-20 15:29:58 UTC
+nm_device_ethernet_utils_get_default_wired_name (NMConnection *const*connections)

Add a space between "const" and "*"?

LGTM.
Comment 2 Thomas Haller 2016-05-24 10:47:04 UTC
after ACK from lrintel, merged to master:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=487dcf7e550a1263af722ace8f4577f8f048d885