After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766540 - Add missing library to build of calendar/gui/
Add missing library to build of calendar/gui/
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Calendar
3.20.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
: 766574 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-05-17 01:22 UTC by darkxst
Modified: 2016-05-19 08:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix build with as-needed (973 bytes, patch)
2016-05-17 01:39 UTC, darkxst
committed Details | Review

Description darkxst 2016-05-17 01:22:48 UTC
commit 3e1172efa00da5eed44a9920afdb885abe625b99 introduced another build failure when building with --as-needed.

.libs/libevolution_calendar_la-e-meeting-list-view.o: In function `process_section':
/<<PKGBUILDDIR>>/calendar/gui/e-meeting-list-view.c:954: undefined reference to `eab_parse_qp_email'
collect2: error: ld returned 1 exit status
Comment 1 darkxst 2016-05-17 01:39:37 UTC
Created attachment 328032 [details] [review]
Fix build with as-needed
Comment 2 Milan Crha 2016-05-17 09:35:12 UTC
Thanks for a bug report and patch. The cited commit belong to bug #764426. I tried to reproduce it with -Wl,--as-needed, but it didn't fail here, thus it might be something else probably. In any case, your change is correct, thus:

Created commit 57c5258 in evo master (3.21.2+)
Created commit f957916 in evo gnome-3-20 (3.20.3+)
Comment 3 Milan Crha 2016-05-17 09:53:33 UTC
Ouch, I'm such a... I accidentally committed your fix without referencing you as the commit author. I'm sorry about that. I corrected it by reverting the previous commits and re-committing with the correct author (as specified in the patch):

Created commit 74c1e0d in evo master (3.21.2+)
Created commit a182334 in evo gnome-3-20 (3.20.3+)
Comment 4 Milan Crha 2016-05-19 08:00:33 UTC
*** Bug 766574 has been marked as a duplicate of this bug. ***