After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766517 - GtkAboutDialog should use https:// license URLs
GtkAboutDialog should use https:// license URLs
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-05-16 14:31 UTC by Tristan Heaven
Modified: 2017-07-18 18:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-gtkaboutdialog-use-https-license-URLs.patch (3.17 KB, patch)
2016-05-16 14:31 UTC, Tristan Heaven 		reviewed Details | Review
patch with more descriptive commit message (3.24 KB, patch)
2017-07-14 01:36 UTC, Daniel Aleksandersen 		committed Details | Review

Description Tristan Heaven 2016-05-16 14:31:32 UTC 
Created attachment 327983 [details] [review]
0001-gtkaboutdialog-use-https-license-URLs.patch

https should be preferred where available
Comment 1 Matthias Clasen 2016-05-16 14:37:21 UTC 
Review of attachment 327983 [details] [review]:

The commit message is a bit weak on the 'why' part. No objections otherwise.
Comment 2 Daniel Aleksandersen 2017-07-14 01:36:10 UTC 
Created attachment 355562 [details] [review]
patch with more descriptive commit message

Here is another take at patch with a more descriptive commit message:

    Update the URLs of known licenses to HTTPS
    Use HTTPS by default for security/privacy. Avoids slow redirects.

IS this acceptable,  Matthias Clasen?