After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766515 - playbin: fix suburidecodebin leak
playbin: fix suburidecodebin leak
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 1.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2016-05-16 13:43 UTC by Guillaume Desmottes
Modified: 2016-05-20 06:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

playbin: fix suburidecodebin leak (1.07 KB, patch)
2016-05-16 13:44 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2016-05-16 13:43:36 UTC
Comment 1 Guillaume Desmottes 2016-05-16 13:44:32 UTC
Created attachment 327978 [details] [review]
playbin: fix suburidecodebin leak

We take a ref before removing which was never freeded.
The element is still alive anyway because the group has its own ref as

Fix a leak with the 'test_suburi_error_wrongproto' test.
Comment 2 Sebastian Dröge (slomo) 2016-05-17 06:56:06 UTC
Attachment 327978 [details] pushed as 92343b6 - playbin: fix suburidecodebin leak
Comment 3 Sebastian Dröge (slomo) 2016-05-17 06:57:17 UTC
I wonder why we do the set_locked_state/ref/remove/unref here but not in any other place where elements are removed. It's useful in general if otherwise your element might be set to another state then NULL while removing it (by the bin).