After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766460 - Use GJS M4 macros from autoconf-archive
Use GJS M4 macros from autoconf-archive
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-05-15 00:41 UTC by Philip Chimento
Modified: 2017-08-23 09:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
js: Remove unused imports (13.58 KB, patch)
2016-05-15 00:46 UTC, Philip Chimento 		committed Details | Review
build: Check for GJS GIRs with new macros (1.57 KB, patch)
2016-05-15 00:46 UTC, Philip Chimento 		committed Details | Review
Add GJS macros (1.47 KB, patch)
2016-05-15 00:47 UTC, Philip Chimento 		committed Details | Review
3.22, 3.24, 3.26: Add m4-common as a dependency of gnome-documents (1.81 KB, patch)
2017-08-17 10:44 UTC, Debarshi Ray 		committed Details | Review

Description Philip Chimento 2016-05-15 00:41:30 UTC 
I added some GJS M4 macros to autoconf-archive [1], so I'd like to port gnome-documents to use them, as an example for other projects to follow.

Here's a patch that uses the macros to check for all the GIRs required by GJS, preceded by a cleanup patch that removes unnecessary imports (at least one GIR was imported but not needed anywhere!)

[1] https://github.com/peti/autoconf-archive/commit/5681cc41bafa702aee1f50161e37d4f34b0216da
Comment 1 Philip Chimento 2016-05-15 00:46:51 UTC 
Created attachment 327907 [details] [review]
js: Remove unused imports

While looking for GI imports to check at configure time, I found that
gi.Soup was imported but never used anywhere. As long as I'm removing
that, I went ahead and removed all the other unused imports.
Comment 2 Philip Chimento 2016-05-15 00:46:55 UTC 
Created attachment 327908 [details] [review]
build: Check for GJS GIRs with new macros

This uses the new AX_PROG_GJS, AX_CHECK_GIRS_GJS, and
AX_CHECK_GIR_SYMBOLS_GJS macros in autoconf-archive to check for the
GJS path and the necessary GIR files in configure.ac
Comment 3 Philip Chimento 2016-05-15 00:47:54 UTC 
Created attachment 327909 [details] [review]
Add GJS macros

These are useful for Gnome's Javascript applications.
Comment 4 Philip Chimento 2016-05-15 00:48:29 UTC 
And the last one is a patch for m4-common, to get the new macros into jhbuild.
Comment 5 Cosimo Cecchi 2016-05-15 21:47:48 UTC 
Review of attachment 327907 [details] [review]:

Looks good, thanks for this!
Comment 6 Cosimo Cecchi 2016-05-15 21:49:13 UTC 
Review of attachment 327908 [details] [review]:

Looks good
Comment 7 Cosimo Cecchi 2016-05-15 21:49:24 UTC 
Review of attachment 327909 [details] [review]:

Looks good
Comment 8 Philip Chimento 2016-05-15 22:19:14 UTC 
Thanks for the review, pushed!
Comment 9 Alessandro Bono 2016-05-17 13:32:05 UTC 
At this time there are only two of three patches in master. The third one is missing, is this intended?
Comment 10 Philip Chimento 2016-05-18 06:27:22 UTC 
The third patch is for the m4-common repository, it's been pushed as well.
Comment 11 Alessandro Bono 2016-05-18 16:25:09 UTC 
Ok! Sorry about the noise.
Comment 12 Debarshi Ray 2017-08-17 10:44:35 UTC 
Created attachment 357793 [details] [review]
3.22, 3.24, 3.26: Add m4-common as a dependency of gnome-documents

Don't we also need to add m4-common as a dependency of gnome-documents?
Comment 13 Philip Chimento 2017-08-21 04:11:51 UTC 
Makes sense to me.
Comment 14 Debarshi Ray 2017-08-23 09:35:43 UTC 
Thanks, Philip. Pushed to master.