GNOME Bugzilla – Bug 766452
PangoAttribute could be boxed
Last modified: 2018-05-22 13:18:58 UTC
It looks like PangoAttribute could be made into a boxed type (using pango_attribute_copy and pango_attribute_destroy as the copy and free functions in G_DEFINE_BOXED_TYPE). This is useful for bindings, since otherwise one needs to write special handling functions for PangoAttribute, to make sure the associated memory is managed correctly. (In the Haskell bindings we are currently doing this, but it would be good to remove the special case down the road.) Could it be possible to make PangoAttribute into a boxed type? Basically adding G_DEFINE_BOXED_TYPE (PangoAttribute, pango_attribute, pango_attribute_copy, pango_attribute_destroy) I think.
A patch would be welcome for this
Created attachment 350594 [details] [review] Patch that makes PangoAttribute a boxed type Here's a patch that implements this. It may need a different version macro.
When testing this patch I got double free with this simple python code: > from gi.repository import Pango > a = Pango.attr_weight_new(Pango.Weight.BOLD) > del a
Oops, indeed when testing python was not using the right library, it works with double free. Sorry for the noise
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/pango/issues/259.