After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766431 - libsndfile: Add recipe
libsndfile: Add recipe
Status: RESOLVED INCOMPLETE
Product: GStreamer
Classification: Platform
Component: cerbero
git master
Other All
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-14 11:14 UTC by Marcin Lewandowski
Modified: 2018-05-07 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that adds libsndfile (936 bytes, patch)
2016-05-14 11:14 UTC, Marcin Lewandowski 		none Details | Review
Patch that adds sndfile to gst-plugins-bad (3.56 KB, patch)
2016-05-14 11:20 UTC, Marcin Lewandowski 		none Details | Review
Patch that adds libsndfile (3.52 KB, patch)
2016-06-26 20:38 UTC, Marcin Lewandowski 		needs-work Details | Review
libsndfile.recipe (937 bytes, patch)
2016-06-27 10:58 UTC, Marcin Lewandowski 		accepted-commit_now Details | Review
Add libsndfile dependency to gst-plugins-bad (2.41 KB, patch)
2016-06-27 11:01 UTC, Marcin Lewandowski 		needs-work Details | Review

Description Marcin Lewandowski 2016-05-14 11:14:07 UTC 
Created attachment 327870 [details] [review]
Patch that adds libsndfile

The attached patch adds recipe for libsndfile as it was suggested at https://bugzilla.gnome.org/show_bug.cgi?id=765183#c1
Comment 1 Marcin Lewandowski 2016-05-14 11:20:58 UTC 
Created attachment 327872 [details] [review]
Patch that adds sndfile to gst-plugins-bad
Comment 2 Sebastian Dröge (slomo) 2016-05-15 07:43:06 UTC 
Review of attachment 327872 [details] [review]:

You also need to add libsndfile to the .package that ships the gstsf plugin

::: recipes/gst-plugins-bad-1.0-static.recipe
@@ +15,3 @@
         --disable-mpeg2enc --disable-mplex --disable-musepack --disable-mythtv \
         --disable-neon --disable-ofa --disable-openal --disable-opencv \
+        --disable-pvr --disable-sdl --endable-sndfile \

Typo, endable :) But we also don't generally enable all plugins, let the autodetection handle it
Comment 3 Marcin Lewandowski 2016-06-26 20:38:32 UTC 
Created attachment 330410 [details] [review]
Patch that adds libsndfile
Comment 4 Sebastian Dröge (slomo) 2016-06-27 06:43:47 UTC 
Comment on attachment 330410 [details] [review]
Patch that adds libsndfile

Please also include the change to actually add libsndfile here. Thanks!

Also libsndfile will have to be added to the correct .package file as dependency (the one that is going to contain the plugin).
Comment 5 Marcin Lewandowski 2016-06-27 10:58:09 UTC 
Created attachment 330427 [details] [review]
libsndfile.recipe
Comment 6 Marcin Lewandowski 2016-06-27 11:01:31 UTC 
Created attachment 330428 [details] [review]
Add libsndfile dependency to gst-plugins-bad
Comment 7 Sebastian Dröge (slomo) 2016-06-27 12:55:05 UTC 
Comment on attachment 330428 [details] [review]
Add libsndfile dependency to gst-plugins-bad

libsndfile will have to be added to the correct .package file as dependency (the one that is going to contain the plugin).
Comment 8 Sebastian Dröge (slomo) 2016-11-01 18:59:17 UTC 
Ping?
Comment 9 Sebastian Dröge (slomo) 2018-05-07 15:48:04 UTC 
Closing this bug report as no further information has been provided. Please feel free to reopen this bug report if you can provide the information that was asked for in a previous comment.
Thanks!