After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766405 - Stack shows incorrect frame in widget factory on wayland
Stack shows incorrect frame in widget factory on wayland
Product: gtk+
Classification: Platform
Component: Backend: Wayland
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Reported: 2016-05-14 01:52 UTC by Matt Watson
Modified: 2016-05-18 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Fixes stack to always have consistent state. (1.02 KB, patch)
2016-05-14 02:02 UTC, Matt Watson
committed Details | Review

Description Matt Watson 2016-05-14 01:52:29 UTC
From Timm Bäder on irc, on wayland sometimes stack shows a double drawn frame in the widget factory.

I believe the problem is because for some reason after triggering a stack page transition, the stack is being drawn before its first tick callback. A gdk window is positioned wrong until that callback.

Probably good for stack to always have consistent state, and have a patch for that which fixes this problem. But no idea if that ordering of draw->tick callback is expected, so opening the bug in case someone who knows more on the wayland side wants to dig in there.
Comment 1 Matt Watson 2016-05-14 02:02:01 UTC
Created attachment 327845 [details] [review]
Fixes stack to always have consistent state.
Comment 2 Matthias Clasen 2016-05-15 17:29:08 UTC
Review of attachment 327845 [details] [review]:

I agree that always having a consistent state is a good idea.
Comment 3 Matt Watson 2016-05-16 21:04:45 UTC
Committed that fix.