After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766390 - glibc 2.48.1 failed tests fileutils
glibc 2.48.1 failed tests fileutils
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.48.x
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
: 741007 743840 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-05-13 18:45 UTC by Дилян Палаузов
Modified: 2018-04-13 14:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tests: Skip some of the fileutils tests when running as root (1.23 KB, patch)
2018-04-12 11:45 UTC, Philip Withnall
committed Details | Review

Description Дилян Палаузов 2016-05-13 18:45:14 UTC
I have gcc 6.1.1 20160513 and libc 2.19, linux 3.16.0-4-amd64

Doing "make check" reports:

ERROR: fileutils
================

# random seed: R02S2b753c4a5405975a0b7e798d195979e9
1..15
# Start of fileutils tests
ok 1 /fileutils/build-path
PASS: fileutils 1 /fileutils/build-path
ok 2 /fileutils/build-pathv
PASS: fileutils 2 /fileutils/build-pathv
ok 3 /fileutils/build-filename
PASS: fileutils 3 /fileutils/build-filename
ok 4 /fileutils/build-filenamev
PASS: fileutils 4 /fileutils/build-filenamev
ok 5 /fileutils/mkdir-with-parents
PASS: fileutils 5 /fileutils/mkdir-with-parents
ok 6 /fileutils/format-size-for-display
PASS: fileutils 6 /fileutils/format-size-for-display
ok 7 /fileutils/errors
PASS: fileutils 7 /fileutils/errors
ok 8 /fileutils/basename
PASS: fileutils 8 /fileutils/basename
ok 9 /fileutils/dir-make-tmp
PASS: fileutils 9 /fileutils/dir-make-tmp
ok 10 /fileutils/file-open-tmp
PASS: fileutils 10 /fileutils/file-open-tmp
ok 11 /fileutils/mkstemp
PASS: fileutils 11 /fileutils/mkstemp
ok 12 /fileutils/mkdtemp
PASS: fileutils 12 /fileutils/mkdtemp
ok 13 /fileutils/set-contents
PASS: fileutils 13 /fileutils/set-contents
**
GLib:ERROR:fileutils.c:865:test_stdio_wrappers: assertion failed: (errno == EACCES)
ok 14 /fileutils/read-link
PASS: fileutils 14 /fileutils/read-link
../../tap-test: line 5: 12730 Aborted                 $1 -k --tap
# GLib:ERROR:fileutils.c:865:test_stdio_wrappers: assertion failed: (errno == EACCES)
ERROR: fileutils - too few tests run (expected 15, got 14)
ERROR: fileutils - exited with status 134 (terminated by signal 6?)

PASS: testing
=============

# random seed: R02S44ce2061c0eb14d05c35e37b22e5cb38
1..25
# Start of random-generator tests
ok 1 /random-generator/rand-1
PASS: testing 1 /random-generator/rand-1
ok 2 /random-generator/rand-2
PASS: testing 2 /random-generator/rand-2
ok 3 /random-generator/random-conversions
PASS: testing 3 /random-generator/random-conversions
# End of random-generator tests
# Start of misc tests
ok 4 /misc/assertions
PASS: testing 4 /misc/assertions
ok 5 /misc/test-data
PASS: testing 5 /misc/test-data
ok 6 /misc/primetoul
PASS: testing 6 /misc/primetoul
ok 7 /misc/fatal-log-handler
PASS: testing 7 /misc/fatal-log-handler
ok 8 /misc/expected-messages
PASS: testing 8 /misc/expected-messages
ok 9 /misc/dash-p
PASS: testing 9 /misc/dash-p
ok 10 /misc/nonfatal
PASS: testing 10 /misc/nonfatal
ok 11 /misc/skip # SKIP Skipped should count as passed, not failed
SKIP: testing 11 /misc/skip # SKIP Skipped should count as passed, not failed
ok 12 /misc/skip-all
PASS: testing 12 /misc/skip-all
ok 13 /misc/fail
PASS: testing 13 /misc/fail
ok 14 /misc/incomplete
PASS: testing 14 /misc/incomplete
ok 15 /misc/timeout
PASS: testing 15 /misc/timeout
# Start of assertions tests
# Start of subprocess tests
# End of subprocess tests
# End of assertions tests
# Start of fatal-log-handler tests
# Start of subprocess tests
# End of subprocess tests
# End of fatal-log-handler tests
# Start of expected-messages tests
ok 16 /misc/expected-messages/expect-error
PASS: testing 16 /misc/expected-messages/expect-error
# Test-DEBUG: should be ignored
ok 17 /misc/expected-messages/skip-debug
PASS: testing 17 /misc/expected-messages/skip-debug
# Start of subprocess tests
# End of subprocess tests
# End of expected-messages tests
# Start of dash-p tests
ok 18 /misc/dash-p/child
PASS: testing 18 /misc/dash-p/child
# Start of child tests
ok 19 /misc/dash-p/child/sub
PASS: testing 19 /misc/dash-p/child/sub
ok 20 /misc/dash-p/child/sub2
PASS: testing 20 /misc/dash-p/child/sub2
# Start of sub tests
# Start of subprocess tests
# End of subprocess tests
# End of sub tests
# End of child tests
# Start of subprocess tests
# Start of hidden tests
# End of hidden tests
# End of subprocess tests
# End of dash-p tests
# Start of skip-all tests
# Start of subprocess tests
# End of subprocess tests
# End of skip-all tests
# End of misc tests
# Start of forking tests
# testing:ERROR:testing.c:127:test_fork_fail: code should not be reached
ok 21 /forking/fail assertion
PASS: testing 21 /forking/fail assertion
ok 22 /forking/patterns
PASS: testing 22 /forking/patterns
# End of forking tests
# Start of trap_subprocess tests
ok 23 /trap_subprocess/fail
PASS: testing 23 /trap_subprocess/fail
ok 24 /trap_subprocess/no-such-test
PASS: testing 24 /trap_subprocess/no-such-test
ok 25 /trap_subprocess/patterns
PASS: testing 25 /trap_subprocess/patterns
# End of trap_subprocess tests
Comment 1 Philip Withnall 2018-04-12 11:43:55 UTC
I suspect this is happening because you’re running the tests as root, and hence you won’t get an EACCES error from the filesystem.

Patch coming shortly.
Comment 2 Philip Withnall 2018-04-12 11:45:18 UTC
Created attachment 370852 [details] [review]
tests: Skip some of the fileutils tests when running as root

The tests which check permissions and errors like EACCES aren’t going to
work as root, since root always has permission to do things. Skip them
if running as root.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 3 Philip Withnall 2018-04-12 11:45:31 UTC
*** Bug 743840 has been marked as a duplicate of this bug. ***
Comment 4 Philip Withnall 2018-04-12 11:46:21 UTC
*** Bug 741007 has been marked as a duplicate of this bug. ***
Comment 5 Emmanuele Bassi (:ebassi) 2018-04-13 13:54:51 UTC
Review of attachment 370852 [details] [review]:

Okay
Comment 6 Philip Withnall 2018-04-13 14:34:29 UTC
Attachment 370852 [details] pushed as c8cbfd5 - tests: Skip some of the fileutils tests when running as root