After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766385 - In $project_path/Makefile.am's SUBDIRS 'src' should come before 'po' (faster builds, etc.)
In $project_path/Makefile.am's SUBDIRS 'src' should come before 'po' (faster ...
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-13 16:42 UTC by Raunaq
Modified: 2016-05-14 16:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bug 766385 - Changes in Makefile.am (694 bytes, patch)
2016-05-13 16:53 UTC, Raunaq 		none Details | Review
Bug 766385 - Changes in Makefile.am (949 bytes, patch)
2016-05-14 08:05 UTC, Raunaq 		committed Details | Review

Description Raunaq 2016-05-13 16:42:29 UTC 
In $project_path/Makefile.am's SUBDIRS 'src' should come before 'po'
Comment 1 Raunaq 2016-05-13 16:53:23 UTC 
Created attachment 327809 [details] [review]
Bug 766385 - Changes in Makefile.am

'src' should come before 'po'
Comment 2 Christian Hergert 2016-05-13 19:23:04 UTC 
Review of attachment 327809 [details] [review]:

wrong file, take a look at plugins/autotools-templates/autotools_templates/resources/Makefile.am
Comment 3 Raunaq 2016-05-14 08:05:32 UTC 
Created attachment 327855 [details] [review]
Bug 766385 - Changes in Makefile.am

In $project_path/Makefile.am's SUBDIRS 'src' should come before 'po'
Comment 4 Christian Hergert 2016-05-14 09:20:42 UTC 
Review of attachment 327855 [details] [review]:

LGTM
Comment 5 Christian Hergert 2016-05-14 16:10:45 UTC 
Attachment 327855 [details] pushed as 458e6bb - Bug 766385 - Changes in Makefile.am