After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766382 - v4l2videodec: use visible size, not coded size, for downstream negotiation filter
v4l2videodec: use visible size, not coded size, for downstream negotiation fi...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.8.1
Other Linux
: Normal normal
: 1.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-13 15:50 UTC by Philipp Zabel
Modified: 2016-06-07 21:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
v4l2videodec: use visible size, not coded size, for downstream negotiation filter (3.50 KB, patch)
2016-05-13 15:50 UTC, Philipp Zabel 		committed Details | Review

Description Philipp Zabel 2016-05-13 15:50:55 UTC 
Created attachment 327800 [details] [review]
v4l2videodec: use visible size, not coded size, for downstream negotiation filter

gst_v4l2_probe_caps() returns the coded size, not the visible size. Subtract the known padding from probed caps with the coded size before using them as filter for caps negotiation with downstream elements.
Comment 1 Nicolas Dufresne (ndufresne) 2016-05-14 09:22:48 UTC 
Review of attachment 327800 [details] [review]:

::: sys/v4l2/gstv4l2videodec.c
@@ +533,3 @@
     gst_buffer_unref (codec_data);
 
+    /* For decoders G_FMT returns coded size, G_SELECTION returns visible size

That's odd, as this isn't the case on S5P MFC. You can have padding in your buffers without exposing the coded size. Do we have a general agreement around developer that this is the way to go ? Do yo have a patch for MFC ?
Comment 2 Nicolas Dufresne (ndufresne) 2016-05-14 19:40:01 UTC 
Sorry, I see, MFC is also this way. This is another regression caused by the negotiation of the format. Thanks for the patch.
Comment 3 Philipp Zabel 2016-05-17 10:37:39 UTC 
You can with multiplane formats. For single-planar YUV420 formats it is not possible to have vertical padding because the chroma planes start right after the luma plane.
Comment 4 Nicolas Dufresne (ndufresne) 2016-06-06 21:37:24 UTC 
Will also go in 1.8.

Attachment 327800 [details] pushed as 1f31715 - v4l2videodec: use visible size, not coded size, for downstream negotiation filter
Comment 5 Nicolas Dufresne (ndufresne) 2016-06-07 21:20:52 UTC 
Branch: 1.8
Commit: b957760a6bf80b1974fc08f3ae8ce47a54570f8f