GNOME Bugzilla – Bug 766334
Please consider API versioning the include directory and library name
Last modified: 2016-08-14 22:04:58 UTC
Hi, libgames-support already uses an API version for its pkg-config file and the Vala support file. I think it would be more consistent to follow what other (GNOME) libraries do and also API-version the include directory and library name, i.e. use /usr/include/gnome-games-1.0/ /usr/lib/libgames-support-1.0.so*
Ooops. :( I guess this can be changed for the next stable release, without incrementing the pkg-config API version. Everything should Just Work so long as you rebuild dependent applications.
Created attachment 332418 [details] [review] Add API version to include directory and library name This should have been done from the start; it was a serious oversight. Unfortunately it means all dependent games (gnome-klotski, gnome-robots, gnome-nibbles, gnome-mines) will need to be rebuilt. Fortunately no changes in the games should be required, as the games all get the include directory and library name from pkg-config. Sneakily rename the include directory location while we're at it. (Michael, does this look good to you?)
Created attachment 332419 [details] [review] Add API version to include directory and library name This should have been done from the start; it was a serious oversight. Unfortunately it means all dependent games (gnome-klotski, gnome-robots, gnome-nibbles, gnome-mines) will need to be rebuilt. Fortunately no changes in the games should be required, as the games all get the include directory and library name from pkg-config. Sneakily rename the include directory location while we're at it.
Review of attachment 332419 [details] [review]: LGTM
LGTM as well
Thanks for reviewing Michael, and thanks for the patch Michael ;) Pushed to master To ssh://ssareen@git.gnome.org/git/libgames-support 4e5c055..5792592 master -> master