After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766325 - st: Use case-insensitive shortcuts
st: Use case-insensitive shortcuts
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-05-12 13:21 UTC by Florian Müllner
Modified: 2016-05-12 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
st: Use case-insensitive shortcuts (2.82 KB, patch)
2016-05-12 13:21 UTC, Florian Müllner
committed Details | Review
text: Bind <ctrl>A in addition to <ctrl>a (1.42 KB, patch)
2016-05-12 13:45 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2016-05-12 13:21:25 UTC
See patch.
Comment 1 Florian Müllner 2016-05-12 13:21:30 UTC
Created attachment 327704 [details] [review]
st: Use case-insensitive shortcuts

For shortcuts that involve a letter (like <ctrl>c), we currently only
accept the lower-case variant. This makes shortcuts awkward to use when
caps-lock is active, and is inconsistent with GTK+, so accept upper-case
variants as well.
Comment 2 Florian Müllner 2016-05-12 13:45:03 UTC
Created attachment 327708 [details] [review]
text: Bind <ctrl>A in addition to <ctrl>a

The 'select-all' action is currently only bound to <ctrl>a, which makes
it awkward to use when caps-lock is active, and is inconsistent with GTK+.
Just accept both upper- and lower-case variants.

https://bugzilla.gnome.org/show_bug.cgi?id=766326
Comment 3 Rui Matos 2016-05-12 17:45:47 UTC
Review of attachment 327704 [details] [review]:

Since we don't have a gtkkeyhash.c equivalent, this will do. Thankfully we don't have many of these shortcuts
Comment 4 Rui Matos 2016-05-12 17:45:57 UTC
Review of attachment 327708 [details] [review]:

ok
Comment 5 Florian Müllner 2016-05-12 17:51:30 UTC
Attachment 327704 [details] pushed as 387f514 - st: Use case-insensitive shortcuts