GNOME Bugzilla – Bug 766285
gnome-shell Wayland application tracking broken for Empathy
Last modified: 2016-05-11 20:26:44 UTC
The shell application tracking is broken under Wayland for Empathy. I have a missing icon placeholder in the app menu, and the name next to the menu is "empathy-chat" or "empathy-call" instead of "Empathy". It works under X11. I'm pretty sure we had a plan to handle this last year, but frankly I don't remember what it was. :)
The problem is likely that Empathy uses gdk_set_program_class() instead of g_set_prgname()[0]. That's fine on X11, but unlikely to have any effect on wayland where the program class is only used as fallback[1]. We could try to come up with a prgname/program_class heuristics in GDK that fixes empathy without breaking anything else, but by far the easiest fix would be to do the s/gdk_set_program_class/g_set_prgname/ one-liner in empathy ... [0] https://git.gnome.org/browse/empathy/tree/src/empathy-chat.c#n118 [1] https://git.gnome.org/browse/gtk+/tree/gdk/wayland/gdkwindow-wayland.c#n1343
(In reply to Florian Müllner from comment #1) > We could try to come up with a prgname/program_class heuristics in GDK that > fixes empathy without breaking anything else, but by far the easiest fix > would be to do the s/gdk_set_program_class/g_set_prgname/ one-liner in > empathy ... Let's just fix Empathy! (I'm temporarily not set up with a development environment at the moment; would be great if someone else could handle this.)
Created attachment 327656 [details] [review] Set prgname instead of program_class The former always wins for application matching when using the wayland backend. Obvious patch, compile-tested only.
Review of attachment 327656 [details] [review]: Thanks
Attachment 327656 [details] pushed as f4148c3 - Set prgname instead of program_class