After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766281 - utils/json_from_string: Don't reset user-provided error argument
utils/json_from_string: Don't reset user-provided error argument
Status: RESOLVED FIXED
Product: json-glib
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: json-glib-maint
json-glib-maint
Depends on:
Blocks:
 
 
Reported: 2016-05-11 15:18 UTC by Heinrich Fink
Modified: 2017-03-18 19:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to restore error propagation (857 bytes, patch)
2016-05-11 15:18 UTC, Heinrich Fink 		committed Details | Review

Description Heinrich Fink 2016-05-11 15:18:36 UTC 
Created attachment 327648 [details] [review]
patch to restore error propagation

While testing json_from_string, I found that if parsing fails, I never get an error about the failure. The attached one-liner patch should fix this.
Comment 1 Emmanuele Bassi (:ebassi) 2017-03-18 19:01:05 UTC 
Review of attachment 327648 [details] [review]:

You're absolutely right.