After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766259 - Selected calendars gets reselected when deselecting one calendar
Selected calendars gets reselected when deselecting one calendar
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: User Interface
3.20.x
Other Linux
: Low minor
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-11 09:08 UTC by Marcus Lundblad
Modified: 2017-04-17 18:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
window: change check button state when a source is enabled (3.72 KB, patch)
2016-05-20 14:43 UTC, Georges Basile Stavracas Neto
committed Details | Review

Description Marcus Lundblad 2016-05-11 09:08:34 UTC
When using the calendar button in the header bar. Deselecting one calendar makes the remaining selected calendars gets automatically deselected and then immediatly reslected, triggering the selection animation for the check marks. This looks a bit weird and jarring.
Comment 1 Marinus Schraal 2016-05-11 10:17:36 UTC
Confirmed, I've been seeing this behaviour as well.

From the looks of it I'm not sure the subsequent checkboxes actually get deselected or that they just get re-triggered to do the CSS animation for checked checkboxes.
Comment 2 Georges Basile Stavracas Neto 2016-05-20 14:43:24 UTC
Created attachment 328262 [details] [review]
window: change check button state when a source is enabled

The attached patch fix the issue. Instead of destroying and readding each row when the checkbutton gets selected, simply change the check's active state.
Comment 3 Georges Basile Stavracas Neto 2016-05-20 14:44:00 UTC
Attachment 328262 [details] pushed as 7553d51 - window: change check button state when a source is enabled