GNOME Bugzilla – Bug 766216
Responsive design for Damned Lies
Last modified: 2016-05-18 17:54:13 UTC
Created attachment 327570 [details] [review] Responsive design patch It is based on a customized Bootstrap [1] with some of it's components left out. Some of the main changes are: - Damned Lies logo is now an image (this allow us to reduce the CSS hacks for smartphone/tablet view) - Cleaner layout for vertimus detail page on mobile. Action time is hidden and replaced with an icon that show/hide the time. But there's room for improvement mostly for the "Used in releases" and Statistics sections. - Updated JQuery version to 1.9.1 (minimun requirement for Bootstrap to work). - Added jquery-migrate 1.3.0 as a requirement of JQuery 1.9.1 - General template and CSS cleanup And some known bugs (only for smartphones) - Diff page isn't responsive. Can we edit the html generated from difflib's make_table? - Textarea and some elements overflow from the edit forms (branch and team details) and vertimus detail form. [1] http://getbootstrap.com/customize/?id=bb0d43209f900282fe5436df33801648
Created attachment 327571 [details] [review] Source for damned-lies logo
I would like to upgrade jQuery in a separate patch. I'm fine to upgrade to 2.2.3 as I don't care for old IE versions. Is it OK for you? Do you think jQuery migrate is really useful?
(In reply to Claude Paroz from comment #2) > I would like to upgrade jQuery in a separate patch. OK. Do you want all JS related changes in one patch? > I'm fine to upgrade to 2.2.3 as I don't care for old IE versions. Is it OK for you? I'm ok with this! I've tested JQuery 2.x and some things are broken: 1. Sort functionality for tables Original plugin[1] doesn't work, so i'll use this fork [2]. It also has a "saveSort" function, which might be handy to use. [1] https://github.com/christianbach/tablesorter [2] https://github.com/Mottie/tablesorter 2. Modal windows for reduced_po and vertimus_workflow pages We can replace them with Bootstrap's modal dialogs and remove overlayhelpers.js and jquery-tools.js plugins. Apparently the following are also broken with 1.9.1 version, 3. Growfield2 plugin doesn't work I can't find a new version of growfield plugin. A good alternative is https://github.com/jackmoore/autosize 4. JS code on vertimus_detail page that un/check radio button doesn't work Some methods are deprecated so i'll update them. > Do you think jQuery migrate is really useful? Yes it is, If we stick with 1.9.1 version, as it provides some deprecated features/methods for our JQuery plugins (overlayhelpers.js, jquery-tools.js).
I've created a separate report for jQuery version issues: https://bugzilla.gnome.org/show_bug.cgi?id=766232
Tom, can you rebase your patch on top of current master?
Of course, i'm working on it.
Created attachment 327860 [details] [review] Responsive templates for Damned Lies
Claude, i noticed that vertumus workflow links on "About page" return a 404 error. Is it expected with the latest changes?
Thanks for noticing, I fixed that. I also committed the changes about the http to https links. Sorry, You'll have to rebase again :-( Could you also keep the "<div class="mainpage">" in your patch? Even if we don't assign specific styles to this div, it might be useful at some point. It doesn't harm to let the class name to the div.
Created attachment 327869 [details] [review] Make theme templates repsonsive
Created attachment 327873 [details] [review] Make theme responsive Sorry for this. I forgot to add some changes to the patch before.
Comment on attachment 327571 [details] [review] Source for damned-lies logo I'm seeing several references to your local filesystem in the SVG source. Could you please clean that? I guess that most inkspace-prefixed properties are not useful for web display.
Created attachment 328100 [details] Damned lies logo Removed personal data from svg file
Comment on attachment 327873 [details] [review] Make theme responsive Thanks so much Tom!