GNOME Bugzilla – Bug 766213
openjpeg plugin needs to be ported to libopenjp2 v2.1
Last modified: 2016-05-11 06:45:42 UTC
v2.1 was released in 2014 and is the currently-maintained version of OpenJPEG. However, the API/ABI changed so the plugin needs porting to work. See: https://github.com/uclouvain/openjpeg/releases/tag/version.2.1 https://github.com/uclouvain/openjpeg/blob/version.2.1/NEWS
Created attachment 327574 [details] [review] openjpeg: Port to 2.1 and require a pkg-config file for 2.0 and 2.1
Attachment 327574 [details] pushed as 1536f30 - openjpeg: Port to 2.1 and require a pkg-config file for 2.0 and 2.1
@slomo thanks for merging this patch
I can confirm that this patch works with the following pipeline: gst-launch-1.0 -v videotestsrc pattern=ball ! openjpegenc ! openjpegdec ! videoconvert ! ximagesink using the master branches of gstreamer, gst-plugins-base, gst-plugins-bad and OpenJPEG Cool!
It also works with gst-launch-1.0 -v videotestsrc pattern=ball ! openjpegenc ! rtpj2kpay ! rtpj2kdepay ! openjpegdec ! videoconvert ! ximagesink using my patch to rtpj2k payloader, but the background of the pattern is green and the ball is pink. Without rtp, the background is white and the ball is black.
I can see that with the old openjpeg too (1.5), so it's unrelated to my patch. It's probably messing up colorspace caps on the payloader or depayloader. Could you file a new bug for that (for rtpj2kpay/depay)?
Nirbheek, I took a look at the patch code: there are two lines in the decoder where you set a JPWL parameters (JPEG 2000 for Wireless). Did you intend to do this, or did this accidentally slip in? Because JPWL should not be relevant to the patch. Thanks, Aaron
I'm not sure what patch you're looking at, but my patch does not touch JPWL parameters at all.
Ahhh, ok, it must have been in the code already before your patch. There is one isolated reference to JPWL: if (self->ncomps) params.jpwl_exp_comps = self->ncomps; Can we remove these two lines ?
What effect does that have and can we discuss it in a new bug? :) It's unrelated to this one here
Good idea.