After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766207 - Fix build on pre-C99 compilers
Fix build on pre-C99 compilers
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.21.x
Other Windows
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-05-10 08:34 UTC by Fan, Chun-wei
Modified: 2016-05-10 09:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add fallbacks for exp2(), log2(), and INFINITY when necessary (3.38 KB, patch)
2016-05-10 08:34 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2016-05-10 08:34:22 UTC 
Created attachment 327564 [details] [review]
Add fallbacks for exp2(), log2(), and INFINITY when necessary

Hi,

Recently, libgtk made use of C99 math functions and macros like INFINITY, exp2() and log2(), which is not supported universally.  This attempts to add checks for these functions during configure and provide fallbacks for them and INFINITY.

With blessings, thank you!
Comment 1 Paolo Borelli 2016-05-10 08:43:05 UTC 
Review of attachment 327564 [details] [review]:

We already have all the fallback infrastructure in place, so sure, this looks good
Comment 2 Fan, Chun-wei 2016-05-10 09:17:42 UTC 
Hi Paolo,

Thanks for the fast review, I have pushed the patch as 092cb9e2.

With blessings, thank you!