After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766205 - Check box not redrawn on click in selection mode
Check box not redrawn on click in selection mode
Status: RESOLVED FIXED
Product: gnome-clocks
Classification: Applications
Component: world clock
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: Clocks maintainer(s)
Clocks maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-05-10 07:45 UTC by Yanko Kaneti
Modified: 2016-09-03 14:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
icon: Redraw on click in selection mode (819 bytes, patch)
2016-05-10 07:45 UTC, Yanko Kaneti 		accepted-commit_now Details | Review

Description Yanko Kaneti 2016-05-10 07:45:41 UTC 
Created attachment 327560 [details] [review]
icon: Redraw on click in selection mode

This is perhaps one of those issues where a implicit redraw got lost due to gtk changes/optimizations so it has to be explicit...or something changed in gtk in the relation between tree model and drawing.

Attached patch fixes/workaounds it for me


gtk3-3.21.1-1.fc25.x86_64
gnome-clocks-3.20.1-1.fc25.x86_64
Comment 1 Paolo Borelli 2016-05-10 08:05:42 UTC 
Review of attachment 327560 [details] [review]:

this gives me a feeling of dejavu :)
Comment 2 Yanko Kaneti 2016-05-10 08:37:05 UTC 
Pushed as ff8e8d8 on master.
Not sure about gnome-3-20 , there is translation commit on master which should probably be picked up too...
Comment 3 Paolo Borelli 2016-05-10 08:41:17 UTC 
sure, feel free to backport. I usually let the translation team deal with the translations
Comment 4 Yanko Kaneti 2016-05-10 08:46:35 UTC 
Ok since the translation missing was probably the translator not realizing there was a new branch, I've pushed both to gnome-3-20 so that they don't diverge
Comment 5 Michael Catanzaro 2016-06-15 16:45:13 UTC 
Hey Paolo, got time to do a new 3.20 release for this? It's a pretty ugly bug....
Comment 6 Michael Catanzaro 2016-09-02 15:19:46 UTC 
(In reply to Michael Catanzaro from comment #5)
> Hey Paolo, got time to do a new 3.20 release for this? It's a pretty ugly
> bug....

Hi, the latest stable release is still broken. This is a pretty unfortunate issue....
Comment 7 Paolo Borelli 2016-09-03 09:27:33 UTC 
Sorry about that, I really need help with Clocks maintainance...

I release 3.20.2.
Comment 8 Michael Catanzaro 2016-09-03 14:45:16 UTC 
Thanks! Preparing a Fedora update now....