After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766163 - Some header files missing in sys/applemedia/ in gst-plugins-bad-1.8.1.tar.xz
Some header files missing in sys/applemedia/ in gst-plugins-bad-1.8.1.tar.xz
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.8.1
Other Mac OS
: Normal minor
: 1.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-09 09:32 UTC by Seppe Stas
Modified: 2016-07-18 08:24 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Seppe Stas 2016-05-09 09:32:43 UTC
When building gst-plugins-bad on OSX 10.11.4 using the [Homebrew formula](https://github.com/Homebrew/homebrew-core/blob/master/Formula/gst-plugins-bad.rb) with the `with-applemedia` flag, following error occurs:
```
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C shm
  ...
plugin.m:25:10: fatal error: 'corevideomemory.h' file not found
#include "corevideomemory.h"
```

This seems to be caused by [gst-plugins-bad-1.8.1.tar.xz](https://gstreamer.freedesktop.org/src/gst-plugins-bad/gst-plugins-bad-1.8.1.tar.xz) not containing said `corevideomemory.h` file. The file is however present in [the gst-plugins-bad git repo](https://github.com/GStreamer/gst-plugins-bad/blob/1.8.1/sys/applemedia/corevideobuffer.h).

Reported in Homebrew-core as [#1006](https://github.com/Homebrew/homebrew-core/issues/1006)
Comment 1 Sebastian Dröge (slomo) 2016-05-09 09:51:27 UTC
commit 43487482e5c5ec71867acb887d50b8c3f813cd63
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Mon May 9 12:50:47 2016 +0300

    applemedia: Ship all headers in tarballs
    
    Some were missing from noinst_HEADERS.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=766163
Comment 3 Seppe Stas 2016-05-09 10:12:01 UTC
sys/applemedia/iosurfacememory.h (https://github.com/GStreamer/gst-plugins-bad/blob/1.8.1/sys/applemedia/iosurfacememory.h) seems to be missing as well.
Comment 4 Sebastian Dröge (slomo) 2016-05-09 10:41:03 UTC
Yes, I added them both.
Comment 5 Josep Torra Valles 2016-07-17 09:12:41 UTC
Shouldn't this one go to 1.8.x branch?
Comment 6 Tim-Philipp Müller 2016-07-17 19:11:55 UTC
Josep: looks like it! Please cherry-pick it.
Comment 7 Josep Torra Valles 2016-07-18 08:24:53 UTC
The issue affected the 1.8.2 tarball too.

I've cherry-picked the change to address it in 1.8.3