After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766131 - Update modeline parser
Update modeline parser
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: editor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-08 09:39 UTC by Paolo Borelli
Modified: 2016-05-10 19:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bug 766131 - Update modeline parser (1.63 KB, patch)
2016-05-10 16:47 UTC, Raunaq 		committed Details | Review

Description Paolo Borelli 2016-05-08 09:39:16 UTC 
I fixed an issue pointed out by the gcc address sanitizer in the gedit plugin.
You may want to update your copy.
Comment 1 Raunaq 2016-05-08 17:09:42 UTC 
Hi. I would like to work on this bug if that's ok.. Any advice?
Comment 2 Christian Hergert 2016-05-08 18:17:17 UTC 
We do have a few changes in the modeline parser, so you'll need to look to apply the minimal amount of changes. (See libide/modelines/)
Comment 3 Raunaq 2016-05-10 16:47:31 UTC 
Created attachment 327599 [details] [review]
Bug 766131 - Update modeline parser

If while parsing a modeline we already reach \0 we should not
increment the pointer, we must instead break out of the loop.
Comment 4 Raunaq 2016-05-10 16:50:49 UTC 
(In reply to Christian Hergert from comment #2)
> We do have a few changes in the modeline parser, so you'll need to look to
> apply the minimal amount of changes. (See libide/modelines/)

Hi! I have attached a patch wherein changes were made along the lines of those made by Paolo Borelli (https://git.gnome.org/browse/gedit/commit/?id=b3a4e29)

Kindly review and suggest changes!

Thanks
Comment 5 Christian Hergert 2016-05-10 18:51:59 UTC 
Thanks for looking into this!

Attachment 327599 [details] pushed as 441c35f - Bug 766131 - Update modeline parser
Comment 6 Raunaq 2016-05-10 18:53:48 UTC 
(In reply to Christian Hergert from comment #5)
> Thanks for looking into this!
> 
> Attachment 327599 [details] pushed as 441c35f - Bug 766131 - Update modeline
> parser

Can u pls suggest some bug i can work on? :)
Comment 7 Christian Hergert 2016-05-10 19:40:32 UTC 
(In reply to Raunaq from comment #6)
> Can u pls suggest some bug i can work on? :)

Better to ask on IRC so others can answer when I'm not around.