After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766087 - End/Home/PageUp/PageDown ends the visual selection
End/Home/PageUp/PageDown ends the visual selection
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: keybindings
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-07 00:02 UTC by Bastien Nocera
Modified: 2016-05-07 09:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vim: fix home/end/page-up/page-down in selection mode (2.24 KB, patch)
2016-05-07 09:06 UTC, Christian Hergert
committed Details | Review
movements: add whole line page movements (5.55 KB, patch)
2016-05-07 09:06 UTC, Christian Hergert
committed Details | Review

Description Bastien Nocera 2016-05-07 00:02:17 UTC
gnome-builder-3.20.2-1.fc24.x86_64

In vim emulation mode, press Esc a bunch of times, start a visual selection, and try to extend the selection to the end of the line by pressing "End". The selection isn't extended, instead it seems to reset, and moves the cursor.

This is different behaviour from vim, and happens with End/Home/PageUp/PageDown.
Comment 1 Christian Hergert 2016-05-07 09:06:03 UTC
Created attachment 327424 [details] [review]
vim: fix home/end/page-up/page-down in selection mode

Although, it seems that page up/down still isn't quite right in the same
way ctrl+f/b isn't quite right in linewise mode.
Comment 2 Christian Hergert 2016-05-07 09:06:14 UTC
Created attachment 327425 [details] [review]
movements: add whole line page movements

When moving by ctrl+f/b or page-up/down with linewise mode, we would drift
from whole lines pretty quickly. This tries a bit harder to keep the line
selection as whole lines.

It could still use some work at the file edge boundaries, but this is
clearly better than where we were.
Comment 3 Christian Hergert 2016-05-07 09:10:11 UTC
Should be fixed, thanks for testing!

Attachment 327424 [details] pushed as 5ad84ea - vim: fix home/end/page-up/page-down in selection mode
Attachment 327425 [details] pushed as 65d0f84 - movements: add whole line page movements