After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766067 - Disable ambient backlight helper when the session is inactive
Disable ambient backlight helper when the session is inactive
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: power
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2016-05-06 15:48 UTC by Adam Jackson
Modified: 2017-08-21 17:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
power: Allow disabling ALS monitoring even if inactive (1.18 KB, patch)
2017-08-11 16:37 UTC, Bastien Nocera
committed Details | Review

Description Adam Jackson 2016-05-06 15:48:18 UTC
Since the ambient backlight helper is enabled in the gdm session, it runs continuously. Which is bad, because while the user's session is active, the journal fills with messages like:

May 06 11:41:58 dmt pkexec[2021]: gdm: Error executing command as another user: Not authorized [USER=root] [TTY=unknown] [CWD=/var/lib/gdm] [COMMAND=/usr/libexec/gsd-backlight-helper --set-brightness 4000
May 06 11:41:58 dmt gnome-settings-daemon.desktop[1573]: Error executing command as another user: Not authorized
May 06 11:41:58 dmt gnome-settings-daemon.desktop[1573]: This incident has been reported.
Comment 1 Bastien Nocera 2016-05-06 15:51:20 UTC
Pretty sure that's fixed in 3.20.1.
Comment 2 Adam Jackson 2016-05-06 15:59:59 UTC
(In reply to Bastien Nocera from comment #1)
> Pretty sure that's fixed in 3.20.1.

dmt:~% rpm -q gnome-settings-daemon
gnome-settings-daemon-3.20.1-3.fc24.x86_64
Comment 3 Bastien Nocera 2017-02-15 18:00:40 UTC
This was a bug in gnome-session.

*** This bug has been marked as a duplicate of bug 772537 ***
Comment 4 Bastien Nocera 2017-08-11 16:34:46 UTC
It really wasn't though. A logic bug meant that we'd never try to _stop_ receiving events and were constantly trying to set the backlight.
Comment 5 Bastien Nocera 2017-08-11 16:37:36 UTC
Created attachment 357427 [details] [review]
power: Allow disabling ALS monitoring even if inactive

We definitely do want to be able to disable light sensor
monitoring even if we're not in an active session any more.

The only case this conditional was supposed to prevent is
trying to claim the light sensor when the session is inactive.
Anything else should be allowed.
Comment 6 Rui Matos 2017-08-17 13:10:56 UTC
Review of attachment 357427 [details] [review]:

oops, looks fine
Comment 7 Bastien Nocera 2017-08-21 17:10:05 UTC
Attachment 357427 [details] pushed as 476154f - power: Allow disabling ALS monitoring even if inactive