After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766049 - wayland: use g_signal_handler_disconnect()
wayland: use g_signal_handler_disconnect()
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-05-06 08:33 UTC by Christian Hergert
Modified: 2016-05-06 08:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wayland: use g_signal_handler_disconnect() (2.93 KB, patch)
2016-05-06 08:33 UTC, Christian Hergert
committed Details | Review

Description Christian Hergert 2016-05-06 08:33:10 UTC
Use of g_signal_handlers_disconnect_by_func() needs to do more work than
necessary to find all the matching handlers. Instead, just hold on to the
signal identifier and remove it directly so we hit the fast path.

Not terribly ground breaking in terms of performance gains, but its done
enough to be worthwhile.
Comment 1 Christian Hergert 2016-05-06 08:33:15 UTC
Created attachment 327368 [details] [review]
wayland: use g_signal_handler_disconnect()
Comment 2 Carlos Garnacho 2016-05-06 08:44:45 UTC
Review of attachment 327368 [details] [review]:

Cheers, LGTM.