GNOME Bugzilla – Bug 766027
file-operations: avoid scanning the same files
Last modified: 2016-11-24 10:19:37 UTC
See patch.
Created attachment 327348 [details] [review] file-operations: avoid scanning the same files In some situations when operating on a set of files, the same file can be scanned more than once. An example would be when the input set of files contains a directory's child before the directory itself. This leads to wrong progress information being displayed. In order to fix this, keep a set of the files scanned so far.
Review of attachment 327348 [details] [review]: This looks good to me, needs updating to the new code style. Thanks!
Created attachment 336951 [details] [review] file-operations: avoid scanning the same files In some situations when operating on a set of files, the same file can be scanned more than once. An example would be when the input set of files contains a directory's child before the directory itself. This leads to wrong progress information being displayed. In order to fix this, keep a set of the files scanned so far.
Review of attachment 336951 [details] [review]: +1 ^
Attachment 336951 [details] pushed as 24dae9e - file-operations: avoid scanning the same files
For what it's worth, the use of G_FILE_ATTRIBUTE_ID_FILE caused issue for copies over afc (and gvfs in general I think). See bug #774460