After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766027 - file-operations: avoid scanning the same files
file-operations: avoid scanning the same files
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-05 13:40 UTC by Razvan Chitu
Modified: 2016-11-24 10:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
file-operations: avoid scanning the same files (6.36 KB, patch)
2016-05-05 13:40 UTC, Razvan Chitu
none Details | Review
file-operations: avoid scanning the same files (5.35 KB, patch)
2016-10-04 20:45 UTC, Razvan Chitu
committed Details | Review

Description Razvan Chitu 2016-05-05 13:40:21 UTC
See patch.
Comment 1 Razvan Chitu 2016-05-05 13:40:25 UTC
Created attachment 327348 [details] [review]
file-operations: avoid scanning the same files

In some situations when operating on a set of files, the same file can be
scanned more than once. An example would be when the input set of files contains
a directory's child before the directory itself. This leads to wrong progress
information being displayed. In order to fix this, keep a set of the files
scanned so far.
Comment 2 Carlos Soriano 2016-10-04 20:11:01 UTC
Review of attachment 327348 [details] [review]:

This looks good to me, needs updating to the new code style.

Thanks!
Comment 3 Razvan Chitu 2016-10-04 20:45:56 UTC
Created attachment 336951 [details] [review]
file-operations: avoid scanning the same files

In some situations when operating on a set of files, the same file can be
scanned more than once. An example would be when the input set of files contains
a directory's child before the directory itself. This leads to wrong progress
information being displayed. In order to fix this, keep a set of the files
scanned so far.
Comment 4 Carlos Soriano 2016-10-04 20:47:50 UTC
Review of attachment 336951 [details] [review]:

+1 ^
Comment 5 Razvan Chitu 2016-10-04 21:34:24 UTC
Attachment 336951 [details] pushed as 24dae9e - file-operations: avoid scanning the same files
Comment 6 Christophe Fergeau 2016-11-24 10:19:37 UTC
For what it's worth, the use of G_FILE_ATTRIBUTE_ID_FILE caused issue for copies over afc (and gvfs in general I think). See bug #774460