After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765945 - Use good defaults and remove the menuitems from the preferences
Use good defaults and remove the menuitems from the preferences
Status: RESOLVED OBSOLETE
Product: gnome-terminal
Classification: Core
Component: general
3.20.x
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on: 774710
Blocks:
 
 
Reported: 2016-05-03 16:07 UTC by Reda Lazri
Modified: 2021-06-10 21:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Before and after (651.17 KB, image/png)
2016-05-03 16:07 UTC, Reda Lazri
Details
Improved (515.21 KB, image/png)
2016-05-04 14:39 UTC, Reda Lazri
Details

Description Reda Lazri 2016-05-03 16:07:08 UTC
Created attachment 327240 [details]
Before and after

Having the 'theme variant' menuitem as well as the 'open new terminals in' as menus doesn't look good and doesn't work. Instead, choose good defaults (i.e. light theme and new tabs by default) and allow them to be changed via a checkbox.
Comment 1 Christian Persch 2016-05-03 16:14:53 UTC
> doesn't look good
That's just your opinion, not a fact.

> and doesn't work
Works fine here.

> choose good defaults 
They do have good defaults: 'default' for the theme (i.e. follow the global pref), and 'window' for open-in.

(Note that the theme is a tristate, not a boolean.)
Comment 2 Reda Lazri 2016-05-03 20:54:35 UTC
It's not "just my opinion" it's where the design of the GNOME desktop is headed. Open the preferences window of Nautilus and you'll see that it's quite similar to my proposal.

"doesn't work" as in "doesn't work as a UI solution." I'm sure it changes the values when you select it, you can use almost any widget to change the values of dconf, but not all of them fit.
Comment 3 Reda Lazri 2016-05-04 14:39:17 UTC
Created attachment 327298 [details]
Improved

After some very useful feedback from António Fernandes, it now looks like this:
Comment 4 Egmont Koblinger 2016-05-04 16:52:27 UTC
Re your first proposal: I totally agree with Christian.

Re your second proposal: Might be a good direction, but then I guess all the Prefs and Profile Prefs tabs should be reworked to this design.
Comment 5 Egmont Koblinger 2018-01-05 23:14:43 UTC
Shouldn't we follow the GNOME HIG instead (including right-aligned labels, and GtkSwitch instead of GtkCheckButton)? :-)

Probably the Colors tab is the trickiest to convert. If there's a nice mockup for that, I won't be worried about the rest.

https://developer.gnome.org/hig/stable/visual-layout.html.en#label-alignment
Comment 6 Christian Persch 2018-01-05 23:24:47 UTC
(In reply to Egmont Koblinger from comment #5)
> Shouldn't we follow the GNOME HIG instead (including right-aligned labels,

Left-aligned are easier to read, and that's why the the GNOME2 HIG recommended them. I haven't seen the any rationale for the change to right-alignment.

> and GtkSwitch instead of GtkCheckButton)? :-)

Hard veto from me on GtkSwitch :-)
Comment 7 Egmont Koblinger 2018-01-05 23:31:15 UTC
(In reply to Christian Persch from comment #6)

> Left-aligned are easier to read

I could quote your first sentence from comment 1 here :)

By the way, I don't like right-alignedness, nor GtkSwitch either. So let's forget these aspects of HIG here.
Comment 8 Christian Persch 2018-01-06 00:06:31 UTC
(In reply to Egmont Koblinger from comment #7)
> I could quote your first sentence from comment 1 here :)

:-)

Maybe I was a bit too absolutist, but
https://developer.gnome.org/hig-book/unstable/design-text-labels.html.en
does prefer left-alignment and the way it was explained back then was that it's easier for the eye to read left-aligned labels because the eye knows where to start reading each line.

The exception is when the length of the labels is widely disparate, in which case right-alignment makes sure the label isn't too wide from the thing labelled. To me, that means making labels concise and uniform in length, but of course that also challenging to do esp. for translators.
Comment 9 GNOME Infrastructure Team 2021-06-10 21:07:13 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/7669.