After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765926 - mpegtsmux: Set PTS on aligned buffers
mpegtsmux: Set PTS on aligned buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.8.1
Other All
: Normal blocker
: 1.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 762715 (view as bug list)
Depends on:
Blocks: 767332
 
 
Reported: 2016-05-03 08:50 UTC by Jan Alexander Steffens (heftig)
Modified: 2016-06-07 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] mpegtsmux: Set PTS on aligned buffers (1.52 KB, patch)
2016-05-03 08:50 UTC, Jan Alexander Steffens (heftig) 		committed Details | Review

Description Jan Alexander Steffens (heftig) 2016-05-03 08:50:58 UTC 
Created attachment 327201 [details] [review]
[PATCH] mpegtsmux: Set PTS on aligned buffers

This was broken in 09c05df (make "alignment" property more useful for packetisation).
Comment 1 Sebastian Dröge (slomo) 2016-05-03 09:09:58 UTC 
Regression from 1.4 to 1.6
Comment 2 Tim-Philipp Müller 2016-05-08 16:59:34 UTC 
Wonder if it should prefer dts if available?

We should also add a unit test for it.
Comment 3 Sebastian Dröge (slomo) 2016-06-02 07:39:33 UTC 
(In reply to Tim-Philipp Müller from comment #2)
> Wonder if it should prefer dts if available?

What do you mean? To use DTS in place of PTS if no PTS is available? Or to also add the same code for DTS passthrough?

The latter would make sense to me, but otherwise the patch looks good to me.


Jan, can you provide a test for this?
Comment 4 Jan Alexander Steffens (heftig) 2016-06-02 07:55:54 UTC 
Sorry, I have no experience creating tests for elements.
Comment 5 Sebastian Dröge (slomo) 2016-06-02 08:00:52 UTC 
What's your opinion on the DTS?
Comment 6 Jan Alexander Steffens (heftig) 2016-06-02 08:03:22 UTC 
I'm pretty sure the muxer doesn't ever set the DTS of the buffers in the adapter, anyway.

See new_packet_m2ts.
Comment 7 Sebastian Dröge (slomo) 2016-06-02 08:18:50 UTC 
But it probably should, however that can be handled in a separate bug then :)

Tim, ok to go with this patch here?
Comment 8 Tim-Philipp Müller 2016-06-02 09:01:41 UTC 
There's also a patch for the same issue in bug #762715 fwiw.
Comment 9 Sebastian Dröge (slomo) 2016-06-02 09:49:48 UTC 
Comment on attachment 327201 [details] [review]
[PATCH] mpegtsmux: Set PTS on aligned buffers

This one is more complete than the one in the other bug, and slightly simpler. I would go for this one, and we should open another bug for DTS passthrough (which the other patch does a little bit but not really, it needs more changes AFAIU)
Comment 10 Sebastian Dröge (slomo) 2016-06-07 07:28:10 UTC 
Other opinions? I'll merge it otherwise for 1.8.2
Comment 11 Tim-Philipp Müller 2016-06-07 10:17:04 UTC 
Go for it.
Comment 12 Sebastian Dröge (slomo) 2016-06-07 12:11:31 UTC 
commit 851c89ded9c417c462868d287fdf3aefb128f8ac
Author: Jan Alexander Steffens (heftig) <jan.steffens@gmail.com>
Date:   Mon May 2 17:38:50 2016 +0200

    mpegtsmux: Set PTS on aligned buffers
    
    This was broken in 09c05df (make "alignment" property more useful for
    packetisation).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765926
Comment 13 Sebastian Dröge (slomo) 2016-06-07 12:13:02 UTC 
*** Bug 762715 has been marked as a duplicate of this bug. ***