After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765861 - task: avoid context lock when setting source name
task: avoid context lock when setting source name
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-04-30 22:11 UTC by Christian Hergert
Modified: 2016-04-30 22:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
task: avoid context lock when setting source name (947 bytes, patch)
2016-04-30 22:11 UTC, Christian Hergert
committed Details | Review

Description Christian Hergert 2016-04-30 22:11:16 UTC
Just came across this while looking through the code. NBD.
Comment 1 Christian Hergert 2016-04-30 22:11:19 UTC
Created attachment 327082 [details] [review]
task: avoid context lock when setting source name

If you set the source name after attaching to the context, you have to
lock the context to free/assign the new source name.
Comment 2 Matthias Clasen 2016-04-30 22:16:39 UTC
Review of attachment 327082 [details] [review]:

sure
Comment 3 Christian Hergert 2016-04-30 22:18:56 UTC
Attachment 327082 [details] pushed as d95030a - task: avoid context lock when setting source name