After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765729 - qtdemux: Always set a group-id on STREAM_START
qtdemux: Always set a group-id on STREAM_START
Status: RESOLVED WONTFIX
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-28 14:31 UTC by Edward Hervey
Modified: 2016-04-28 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: Always set a group-id on STREAM_START (3.01 KB, patch)
2016-04-28 14:31 UTC, Edward Hervey 		reviewed Details | Review

Description Edward Hervey 2016-04-28 14:31:49 UTC 
See commit
Comment 1 Edward Hervey 2016-04-28 14:31:55 UTC 
Created attachment 326947 [details] [review]
qtdemux: Always set a group-id on STREAM_START

If upstream doesn't provide one (or we are pull-based), create one

And while we're at it, just use a local variable
Comment 2 Sebastian Dröge (slomo) 2016-04-28 14:50:20 UTC 
Review of attachment 326947 [details] [review]:

::: gst/isomp4/qtdemux.c
@@ +7345,3 @@
+      /* Get the group id from upstream, or create one */
+      if (!event || !gst_event_parse_group_id (event, &group_id))
+        group_id = gst_util_group_id_next ();

It should have the same group-id for all streams in the container, and only increase the group id when the next container is played (i.e. forget it also when going back from PAUSED to READY). That's why it was stored in the demuxer struct before.