After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765726 - Impossible to deselect selected lines in index/diff view
Impossible to deselect selected lines in index/diff view
Status: RESOLVED FIXED
Product: gitg
Classification: Applications
Component: gui
git master
Other Linux
: Normal major
: ---
Assigned To: gitg-maint
gitg-maint
: 769675 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-04-28 13:55 UTC by Mindaugas J.
Modified: 2016-08-18 15:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Allow both CTRL and ALT for deselecting lines. (1.43 KB, patch)
2016-08-03 13:02 UTC, Nils Asmussen 		none Details | Review
Allow both CTRL and ALT for deselecting lines. (1.44 KB, patch)
2016-08-03 13:50 UTC, Nils Asmussen 		none Details | Review

Description Mindaugas J. 2016-04-28 13:55:07 UTC 
Once you mark a line by clicking it, it is now impossible to unmark it short of refreshing the whole view and losing the entire selection.

Worked just fine in 3.18
Comment 1 Ignacio Casal Quinteiro (nacho) 2016-04-28 14:17:12 UTC 
You can deselect them pressing alt. I know we should definitely change it to what it was in 3.18.
Comment 2 Mindaugas J. 2016-04-28 18:20:28 UTC 
I can confirm that.

However it interferes with my Openbox move window binding. I'd prefer if you returned to the previous behavior or used CTRL instead.

Still, whichever modifier is used, it virtually has no discovery potential, IMHO.
Comment 3 Nils Asmussen 2016-08-03 13:02:24 UTC 
Created attachment 332613 [details] [review]
Allow both CTRL and ALT for deselecting lines.

Previously, only ALT was supported, which is used for different purposes
by some window managers.
Comment 4 Nils Asmussen 2016-08-03 13:50:02 UTC 
Created attachment 332623 [details] [review]
Allow both CTRL and ALT for deselecting lines.

Previously, only ALT was supported, which is used for different purposes
by some window managers.


Sorry, after all the things I needed to do in the meantime, I forgot to test my last change before attaching it. Now it works.
Comment 5 jessevdk@gmail.com 2016-08-14 07:22:57 UTC 
*** Bug 769675 has been marked as a duplicate of this bug. ***
Comment 6 jessevdk@gmail.com 2016-08-18 15:47:08 UTC 
Reverted to previous behavior on master. Clicking will now again toggle selection as before, which is much more intuitive. In addition, shift+click has been added to allow selecting/deselecting ranges (in addition to rubber banding).