After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765720 - bin: fix leaks in unit test
bin: fix leaks in unit test
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal minor
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-28 12:01 UTC by Guillaume Desmottes
Modified: 2016-05-02 06:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
bin: fix leaks in unit tests (1.70 KB, patch)
2016-04-28 12:02 UTC, Guillaume Desmottes 		none Details | Review
bin: fix leaks in unit tests (2.67 KB, patch)
2016-05-02 05:17 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2016-04-28 12:01:38 UTC 
.
Comment 1 Guillaume Desmottes 2016-04-28 12:02:01 UTC 
Created attachment 326936 [details] [review]
bin: fix leaks in unit tests

The test rely on bus being flushed when setting the bin to the NULL state which
is not the case. This apply only when setting the pipeline state to
NULL.
Comment 2 Sebastian Dröge (slomo) 2016-04-29 07:05:47 UTC 
Comment on attachment 326936 [details] [review]
bin: fix leaks in unit tests

For consistency/correctness it would make sense to do that everywhere where we set a bus on the bin after setting it to NULL state, not only where the actual leaks are happening.
Comment 3 Guillaume Desmottes 2016-05-02 05:17:55 UTC 
Created attachment 327125 [details] [review]
bin: fix leaks in unit tests

The test rely on bus being flushed when setting the bin to the NULL state which
is not the case. This apply only when setting the pipeline state to
NULL.
Comment 4 Sebastian Dröge (slomo) 2016-05-02 06:57:12 UTC 
Attachment 327125 [details] pushed as 391f767 - bin: fix leaks in unit tests