After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765709 - Build failed with bionic toolchain because of missing ifaddrs.h header
Build failed with bionic toolchain because of missing ifaddrs.h header
Status: RESOLVED FIXED
Product: gssdp
Classification: Other
Component: General
0.14.x
Other Linux
: Normal normal
: ---
Assigned To: GUPnP Maintainers
GUPnP Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-28 08:37 UTC by Aurélien Chabot
Modified: 2019-02-22 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix the build on android (1.41 KB, patch)
2016-04-28 08:37 UTC, Aurélien Chabot
committed Details | Review

Description Aurélien Chabot 2016-04-28 08:37:55 UTC
Created attachment 326923 [details] [review]
Patch to fix the build on android

When trying to build with bionic we got this : 

gssdp-socket-source.c:34:21: fatal error: ifaddrs.h: No such file or directory  #include <ifaddrs.h>

The include of ifaddrs.h that is breaking the build was introduce by commit :

        3030bf4cb97db33fcdfe7e69706fdb0f19b0f446
        Port to glib multicast socket functions


It seem there were needed in the first revision of the patch
but not anymore after reviews.

See attached patch that remove those include.
Comment 1 Jens Georg 2016-04-28 08:56:38 UTC
Have you verified build on "normal" Linux?
Comment 2 Aurélien Chabot 2016-04-28 09:55:04 UTC
Yes I did test a normal linux build.
Comment 3 Jens Georg 2016-04-28 10:19:05 UTC
Review of attachment 326923 [details] [review]:

+1