GNOME Bugzilla – Bug 765694
two memory leaks in gvc-mixer-control
Last modified: 2017-04-06 12:38:21 UTC
Created attachment 326892 [details] [review] mixer-control: fix two memory leaks In both cases objects are inserted in hash table by adding extra ref, but existing ref is never removed.
Review of attachment 326892 [details] [review]: This is likely correct, but I'd like you to create a test case for the problem, similar to the one added in 25bf3ed75fa604fa73e8b25241119a993fc659d6. That would make it easy to test the patch, and you could add the valgrind output for those errors in the commit message (likely splitting the patch in 2 as well).
Created attachment 349362 [details] [review] mixer-control: Fix extra reference being leaked In both cases objects are inserted in hash table by adding an extra ref, but the existing reference was never removed. Don't add a reference instead, so we don't end up with a spare one. Based on patch by Alberts Muktupāvels <alberts.muktupavels@gmail.com>
Attachment 349362 [details] pushed as d52194f - mixer-control: Fix extra reference being leaked