After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765682 - [review] merge "nm-sleep-monitor-upower.c" with "nm-sleep-monitor-systemd.c" [th/sleep-monitor-merge-bgo765682]
[review] merge "nm-sleep-monitor-upower.c" with "nm-sleep-monitor-systemd.c" ...
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-27 16:09 UTC by Thomas Haller
Modified: 2016-04-28 11:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Thomas Haller 2016-04-27 16:09:31 UTC 
Both sleep-monitor implementations are fairly trivial and simialar.

Merge them and separate the different code with #if-#else.

That way, we also create the D-Bus proxy instance asynchronously and unify logging.
Comment 1 Dan Williams 2016-04-27 17:17:21 UTC 
Looks mostly OK, but I don't really like "sleep-signal" as a name.  Maybe just "sleeping" or "suspending" since the is_about_to_suspend argument tells the difference?
Comment 2 Thomas Haller 2016-04-28 11:51:49 UTC 
(In reply to Dan Williams from comment #1)
> Looks mostly OK, but I don't really like "sleep-signal" as a name.  Maybe
> just "sleeping" or "suspending" since the is_about_to_suspend argument tells
> the difference?

Fixed.


merged to master: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=e0cf9319b7e4893becfef886a19dd3e31ec76fde