After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765663 - gst_audio_buffer_clip() needs const on segment
gst_audio_buffer_clip() needs const on segment
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-27 09:21 UTC by Kipp
Modified: 2016-04-27 09:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add const qualifier to segment argument (1.45 KB, patch)
2016-04-27 09:21 UTC, Kipp 		committed Details | Review

Description Kipp 2016-04-27 09:21:47 UTC 
Created attachment 326849 [details] [review]
add const qualifier to segment argument

gst_audio_buffer_clip()'s segment argument should be const.  it doesn't modify it, passes it only to other functions that already have the const qualifier, and without it some gymnastics are required to use gst_audio_buffer_clip() with the segment reference returned by gst_event_parse_segment().
Comment 1 Sebastian Dröge (slomo) 2016-04-27 09:26:51 UTC 
commit f7a31a79f424c6482d54a5cb3192e6eb101d9c3e
Author: Kipp Cannon <kipp.cannon@ligo.org>
Date:   Wed Apr 27 18:08:46 2016 +0900

    audio: Add const to segment parameter of gst_audio_buffer_clip()
    
    e.g., allows this to be used with the reference retrieved by
    gst_event_parse_segment().
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765663