Bug 765638 – js: update deps

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 765638 - js: update deps


Summary:	js: update deps


Status:	RESOLVED FIXED

Product:	gnome-code-assistance
Classification:	Other
Component:	general
Version:	unspecified
Hardware:	Other All

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME Code Assistance maintainers
QA Contact:	GNOME Code Assistance maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2016-04-26 21:09 UTC by Giovanni Campagna
Modified:	2016-07-04 18:11 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
js: update deps (1.02 MB, patch) 2016-04-26 21:09 UTC, Giovanni Campagna	committed	Details \| Review
Fix build with vala 0.34 (906 bytes, patch) 2016-06-13 04:47 UTC, Giovanni Campagna	committed	Details \| Review
css: fix compatibility with sass 3.4.22 (1.46 KB, patch) 2016-06-13 04:48 UTC, Giovanni Campagna	committed	Details \| Review

Description Giovanni Campagna 2016-04-26 21:09:50 UTC

Which brings in support for es6

Comment 1 Giovanni Campagna 2016-04-26 21:09:56 UTC

Created attachment 326804 [details] [review]
js: update deps

Comment 2 Ignacio Casal Quinteiro (nacho) 2016-04-27 06:09:46 UTC

Review of attachment 326804 [details] [review]:

Fine for me.

Comment 3 Giovanni Campagna 2016-04-27 18:03:35 UTC

Comment on attachment 326804 [details] [review]
js: update deps

Pushed but forgot to use git-bz

Comment 4 Giovanni Campagna 2016-06-06 22:28:31 UTC

Would it be possible to have a new release that includes this?
Right now I have to start the backend manually from jhbuild, which is quite annoying.

Comment 5 Ignacio Casal Quinteiro (nacho) 2016-06-12 13:45:02 UTC

So it is not distchecking, I am getting this error:

TESTING org.gnome.CodeAssist.v1.css
  TEST object (/) ....................................................... [FAIL]
      org.freedesktop.DBus.Error.Spawn.ChildExited: Process org.gnome.CodeAssist.v1.css exited with status 1

File "../../tests/service", line 403 in run
```
t()
```
File "../../tests/service", line 153 in __call__
```
return f(*self.args, **self.kwargs)
```
File "../../tests/service", line 208 in test_object
```
return self.get_object(path)
```

File "../../tests/service", line 313 in get_object

return self.bus.get_object(self.name, self.full_path(path))

File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 241 in get_object
```
follow_name_owner_changes=follow_name_owner_changes)
```
File "/usr/lib64/python3.5/site-packages/dbus/proxies.py", line 248 in __init__
```
self._named_service = conn.activate_name_owner(bus_name)
```
File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 180 in activate_name_owner
```
self.start_service_by_name(bus_name)
```
File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 278 in start_service_by_name
```
'su', (bus_name, flags)))
```
File "/usr/lib64/python3.5/site-packages/dbus/connection.py", line 651 in call_blocking
```
message, timeout)
```
File "../../tests/service", line 406 in run
```
t()
```
File "../../tests/service", line 153 in __call__
```
return f(*self.args, **self.kwargs)
```
File "../../tests/service", line 212 in test_interface
```
obj = self.get_object(path)
```

File "../../tests/service", line 313 in get_object

return self.bus.get_object(self.name, self.full_path(path))

File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 241 in get_object
```
follow_name_owner_changes=follow_name_owner_changes)
```
File "/usr/lib64/python3.5/site-packages/dbus/proxies.py", line 248 in __init__
```
self._named_service = conn.activate_name_owner(bus_name)
```
File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 180 in activate_name_owner
```
self.start_service_by_name(bus_name)
```
File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 278 in start_service_by_name
```
'su', (bus_name, flags)))
```
File "/usr/lib64/python3.5/site-packages/dbus/connection.py", line 651 in call_blocking
```
message, timeout)
```
File "../../tests/service", line 414 in run
```
t()
```
File "../../tests/service", line 153 in __call__
```
return f(*self.args, **self.kwargs)
```
File "../../tests/service", line 208 in test_object
```
return self.get_object(path)
```

File "../../tests/service", line 313 in get_object

return self.bus.get_object(self.name, self.full_path(path))

File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 241 in get_object
```
follow_name_owner_changes=follow_name_owner_changes)
```
File "/usr/lib64/python3.5/site-packages/dbus/proxies.py", line 248 in __init__
```
self._named_service = conn.activate_name_owner(bus_name)
```
File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 180 in activate_name_owner
```
self.start_service_by_name(bus_name)
```
File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 278 in start_service_by_name
```
'su', (bus_name, flags)))
```
File "/usr/lib64/python3.5/site-packages/dbus/connection.py", line 651 in call_blocking
```
message, timeout)
```
File "../../tests/service", line 417 in run
```
t()
```
File "../../tests/service", line 153 in __call__
```
return f(*self.args, **self.kwargs)
```
File "../../tests/service", line 212 in test_interface
```
obj = self.get_object(path)
```

File "../../tests/service", line 313 in get_object

return self.bus.get_object(self.name, self.full_path(path))

File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 241 in get_object
```
follow_name_owner_changes=follow_name_owner_changes)
```
File "/usr/lib64/python3.5/site-packages/dbus/proxies.py", line 248 in __init__
```
self._named_service = conn.activate_name_owner(bus_name)
```
File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 180 in activate_name_owner
```
self.start_service_by_name(bus_name)
```
File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 278 in start_service_by_name
```
'su', (bus_name, flags)))
```
File "/usr/lib64/python3.5/site-packages/dbus/connection.py", line 651 in call_blocking
```
message, timeout)
```
File "../../tests/service", line 422 in run
```
t()
```
File "../../tests/service", line 153 in __call__
```
return f(*self.args, **self.kwargs)
```
File "../../tests/service", line 212 in test_interface
```
obj = self.get_object(path)
```

File "../../tests/service", line 313 in get_object

return self.bus.get_object(self.name, self.full_path(path))

File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 241 in get_object
```
follow_name_owner_changes=follow_name_owner_changes)
```
File "/usr/lib64/python3.5/site-packages/dbus/proxies.py", line 248 in __init__
```
self._named_service = conn.activate_name_owner(bus_name)
```
File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 180 in activate_name_owner
```
self.start_service_by_name(bus_name)
```
File "/usr/lib64/python3.5/site-packages/dbus/bus.py", line 278 in start_service_by_name
```
'su', (bus_name, flags)))
```
File "/usr/lib64/python3.5/site-packages/dbus/connection.py", line 651 in call_blocking
```
message, timeout)
```

      

Makefile:5083: recipe for target 'check-service' failed
make[1]: *** [check-service] Error 1
make[1]: Leaving directory '/home/nacho/checkout/gnome/gnome-code-assistance/gnome-code-assistance-3.16.0/_build/sub'
Makefile:4561: recipe for target 'distcheck' failed
make: *** [distcheck] Error 1
*** Error during phase build of gnome-code-assistance: ########## Error running make -j16 distcheck  *** [1/1]

Comment 6 Giovanni Campagna 2016-06-13 04:47:42 UTC

Created attachment 329658 [details] [review]
Fix build with vala 0.34

Comment 7 Giovanni Campagna 2016-06-13 04:48:06 UTC

Created attachment 329659 [details] [review]
css: fix compatibility with sass 3.4.22

I'm not exactly sure what this line of code is doing, but it's
present in sass 3.4.9 (in tree) and gone in 3.4.22. Furthermore,
the class Sass::SCSS::ScriptParser is gone in 3.4.22, which makes
it crash at startup.
Just conditionally running it seems to work.

Comment 8 Giovanni Campagna 2016-06-13 04:48:57 UTC

The error had nothing to do with JS, but in any case with the two above patches it distchecks fine for me.

Comment 9 Ignacio Casal Quinteiro (nacho) 2016-06-13 06:35:57 UTC

Review of attachment 329658 [details] [review]:

Looks good

Comment 10 Ignacio Casal Quinteiro (nacho) 2016-06-15 09:31:33 UTC

Review of attachment 329659 [details] [review]:

ok. let's get this in so we can go on with teh release.

Comment 11 Giovanni Campagna 2016-07-04 18:10:58 UTC

I had forgotten about these patches, sorry.

Attachment 329658 [details] pushed as 94c07f7 - Fix build with vala 0.34
Attachment 329659 [details] pushed as c78c117 - css: fix compatibility with sass 3.4.22