After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765618 - Replace GNU -B extension with a more portable -I equivalent in gi-tester
Replace GNU -B extension with a more portable -I equivalent in gi-tester
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: build
unspecified
Other OpenBSD
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-26 16:01 UTC by Jasper Lievisse Adriaanse
Modified: 2016-04-26 20:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use portable -I instead of -B (1.12 KB, patch)
2016-04-26 16:01 UTC, Jasper Lievisse Adriaanse 		reviewed Details | Review

Description Jasper Lievisse Adriaanse 2016-04-26 16:01:23 UTC 
The `-B` option is a GNU extension, replacing it with `-I '^\s*$'` is more portable and will work with OpenBSD too.
Comment 1 Jasper Lievisse Adriaanse 2016-04-26 16:01:56 UTC 
Created attachment 326788 [details] [review]
Use portable -I instead of -B
Comment 2 Colin Walters 2016-04-26 19:43:47 UTC 
Review of attachment 326788 [details] [review]:

Sure, though this needs to be in proper `git format-patch` style.
Comment 3 Colin Walters 2016-04-26 19:45:19 UTC 
Your previous patches were mostly OK on style, if you make it look like e.g. 023a7ed00e33a6a9e5f3fee742d4c210ce108ecd fine by me to commit without another roundtrip.
Comment 4 Jasper Lievisse Adriaanse 2016-04-26 20:52:01 UTC 
Thank you, pushed as dbbb8b36f2573134d46d5a514a86cc82a18e89d9.