After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765603 - Server class in mpris.py throws unexpected exception
Server class in mpris.py throws unexpected exception
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks:
 
 
Reported: 2016-04-26 12:47 UTC by Saiful B. Khan
Modified: 2016-04-26 13:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Always wrap return value in a tuple (955 bytes, patch)
2016-04-26 13:28 UTC, Gaurav Narula 		committed Details | Review

Description Saiful B. Khan 2016-04-26 12:47:25 UTC 
The class 'Server' in mpris.py meant to handle GDbus server objects throws an exception when an interface method returns a list for out_arg signature 'as'.
Comment 1 Gaurav Narula 2016-04-26 13:28:55 UTC 
Created attachment 326757 [details] [review]
Always wrap return value in a tuple
Comment 2 Felipe Borges 2016-04-26 13:33:57 UTC 
Review of attachment 326757 [details] [review]:

thanks for the patch.

::: gnomemusic/mpris.py
@@ +74,3 @@
 
+        # out_args is atleast (signature1). We therefore always wrap the result
+        # as a tuple. Refer to https://bugzilla.gnome.org/show_bug.cgi?id=765603

I guess the description within the commit should be enough.