After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765572 - [VPP][STDE] display with green stripe.
[VPP][STDE] display with green stripe.
Status: RESOLVED NOTGNOME
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-26 03:38 UTC by Fei
Modified: 2016-10-31 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
use sample.h264 took this picture (411.85 KB, image/jpeg)
2016-04-27 09:07 UTC, Fei
Details
use CVWP1_TOSHIBA_E.264 took this picture (502.80 KB, image/jpeg)
2016-04-27 09:09 UTC, Fei
Details
use freh10.264 took this picture (485.88 KB, image/jpeg)
2016-04-27 09:10 UTC, Fei
Details

Description Fei 2016-04-26 03:38:20 UTC
1. Testing Steps:
========================================================================
gst-launch-1.0 filesrc location=sample.264 ! h264parse ! vaapidecode ! vaapipostproc skin-tone-enhancement=TRUE ! vaapisink 

2. Testing Env:
========================================================================
gst_plugins_vaapi:   (master)8c260701514ad3d5a7cf2952cd8a55f9f10f4ebb
libva:               (master)2339d10b9a39ba4f7173053b9eab8d6a151717a5
Libva_intel_driver:  (master)2c1bec03889fe759a33c087a7c107ad84bbb72fb

3. Frequency of Occurence:
========================================================================
100%
Comment 1 Víctor Manuel Jáquez Leal 2016-04-26 06:47:15 UTC
Hi,

Can you share the file sample.264?

My guess is the frame width in that file is not multiple of 16, so the skin-tone-enhance in vaapipostproc will ignore a region: that green bar.

For example, we could resize the frame to a width multiple of 16, before passing the filter, and the bar will go away:

gst-launch-1.0 filesrc location= ~/patterns/sample.264 ! h264parse ! \
  vaapidecode ! vaapipostproc width=336 ! \
  vaapipostproc skin-tone-enhancement=TRUE ! vaapisink
Comment 2 Fei 2016-04-26 10:13:39 UTC
@Victor,you can use below two samples to duplicate this issue. And I resized frame width to multiple of 16, green stripe also exist.

CVWP1_TOSHIBA_E.264
freh10.264
Comment 3 Víctor Manuel Jáquez Leal 2016-04-26 11:11:30 UTC
I can't perceive a green stripe with those samples. 

But I can see it with attachment 325021 [details] and it is because its width is not multiple of 16. (meanwhile both samples you mentioned have frame sizes multiple of 16 -352x288-)

Can you pust a screenshot?
Comment 4 Víctor Manuel Jáquez Leal 2016-04-26 11:11:42 UTC
* s/pust/post
Comment 5 Fei 2016-04-27 09:07:47 UTC
Created attachment 326845 [details]
use sample.h264 took this picture

cmd:
gst-launch-1.0 filesrc location=sample.264 ! h264parse ! vaapidecode ! vaapipostproc width=336 ! vaapipostproc skin-tone-enhancement=TRUE ! vaapisink
Comment 6 Fei 2016-04-27 09:09:11 UTC
Created attachment 326846 [details]
use CVWP1_TOSHIBA_E.264 took this picture

cmd:
 gst-launch-1.0 filesrc location=CVWP1_TOSHIBA_E.264 ! h264parse ! vaapidecode ! vaapipostproc width=336 ! vaapipostproc skin-tone-enhancement=TRUE ! vaapisink
Comment 7 Fei 2016-04-27 09:10:21 UTC
Created attachment 326847 [details]
use freh10.264 took this picture

cmd:
 gst-launch-1.0 filesrc location=freh10.264 ! h264parse ! vaapidecode ! vaapipostproc width=336 ! vaapipostproc skin-tone-enhancement=TRUE ! vaapisink
Comment 8 Fei 2016-04-27 09:11:38 UTC
(In reply to Víctor Manuel Jáquez Leal from comment #3)
> I can't perceive a green stripe with those samples. 
> 
> But I can see it with attachment 325021 [details] and it is because its
> width is not multiple of 16. (meanwhile both samples you mentioned have
> frame sizes multiple of 16 -352x288-)
> 
> Can you pust a screenshot?

Hi Victor, I have uploaded three pictures about this issue, pls have a check.
Comment 9 Víctor Manuel Jáquez Leal 2016-04-27 09:23:06 UTC
Wow!

Thanks! Which hardware are you using? KBL? Because with my HSW-base laptops doesn't show that ugly stripes.
Comment 10 sreerenj 2016-04-27 09:28:09 UTC
If you guys hit any platform specific issues like this recently , the core reason could be this:
https://lists.freedesktop.org/archives/libva/2016-April/003908.html

Try with the the proposed patch in mailing list.
Comment 11 sreerenj 2016-04-27 09:28:45 UTC
(In reply to sreerenj from comment #10)
> If you guys hit any platform specific issues like this recently , the core
> reason could be this:
> https://lists.freedesktop.org/archives/libva/2016-April/003908.html
> 
> Try with the the proposed patch in mailing list.

and this too:
https://lists.freedesktop.org/archives/libva/2016-April/003902.html
Comment 12 Fei 2016-04-29 02:27:34 UTC
libva-intel-driver:4643f94991e4e36ce3a23de63cce9fe543ed1725
gst-vaapi:018ea8b2fc193f64bcaf8f2a58e67d6a806dfce9

I checked with the latest code of intel-driver&gst-vaapi, but problem still exist.

@Victor, you are right, this issue did not happen on HSW&BYT here. Only happened on KBL&APL&SKL&BSW&BDW.
Comment 13 sreerenj 2016-04-29 08:12:45 UTC
(In reply to Fei from comment #12)
> libva-intel-driver:4643f94991e4e36ce3a23de63cce9fe543ed1725
> gst-vaapi:018ea8b2fc193f64bcaf8f2a58e67d6a806dfce9
> 
> I checked with the latest code of intel-driver&gst-vaapi, but problem still
> exist.
> 
> @Victor, you are right, this issue did not happen on HSW&BYT here. Only
> happened on KBL&APL&SKL&BSW&BDW.

I believe it should be investigated from diver side then.
If you have tools other than gstreamer-vaapi, please have a test with those.
Comment 14 sreerenj 2016-06-21 09:44:22 UTC
This driver patch :https://lists.freedesktop.org/archives/libva/2016-June/004030.html 
will fix the issue. Please test and close once the patch land in driver.
Comment 15 Fei 2016-07-11 02:26:13 UTC
verify Ok:

libva:
commit c36971c682d890681fe839bbaa8a348fe845aa42
libva-intel:
commit bcde10dac40cbc4c8502fa519404c9379372184b
gst-vaapi:
commit 6970dc127764129a6bcb06fcceb600e057346796