After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765558 - tel: URIs should be URI-escaped when copying
tel: URIs should be URI-escaped when copying
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2016-04-25 20:39 UTC by Marcus Lundblad
Modified: 2016-04-26 21:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
osmEditDialog: URI-escape tel: URIs when copying to the phone field (1.05 KB, patch)
2016-04-25 20:50 UTC, Marcus Lundblad
accepted-commit_now Details | Review

Description Marcus Lundblad 2016-04-25 20:39:07 UTC
When copying tel: URIs (i.e. from a web page) and pasting in to the OSM edit dialog (in the phone field), the URI protocol part is omitted (tel:). The rest of the text of the link is copied verbatim.
In some cases, however, the links contains HTML-encoded entities (there is an example of such a tel: link on this page http://www.domarringensskola.uppsala.se/ this link in this case is tel:018-727%2066%2016).

We should probably unescape this string to make this a bit more convinient to use.
Comment 1 Marcus Lundblad 2016-04-25 20:50:19 UTC
Created attachment 326713 [details] [review]
osmEditDialog: URI-escape tel: URIs when copying to the phone field
Comment 2 Jonas Danielsson 2016-04-26 04:43:04 UTC
Review of attachment 326713 [details] [review]:

Looks neat!