After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765543 - general: merge libnautilus-private to src
general: merge libnautilus-private to src
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-25 14:31 UTC by Carlos Soriano
Modified: 2016-04-25 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
general: merge libnautilus-private to src (118.28 KB, patch)
2016-04-25 14:31 UTC, Carlos Soriano
committed Details | Review

Description Carlos Soriano 2016-04-25 14:31:40 UTC
.
Comment 1 Carlos Soriano 2016-04-25 14:31:46 UTC
Created attachment 326694 [details] [review]
general: merge libnautilus-private to src

And fix make distcheck.

Although libnautilus-private seem self contained, it was actually
depending on the files on src/ for dnd.
Not only that, but files in libnautilus-private also were depending on
dnd files, which you can guess it's wrong.

Before the desktop split, this was working because the files were
distributed, but now was a problem since we reestructured the code, and
now nautilus being a library make distcheck stop working.

First solution was try to fix this inter dependency of files, but at
some point I realized that there was no real point on splitting some of
those files, because for example, is perfectly fine for dnd to need to
access the window functions, and it's perfectly fine for the widgets
in the private library to need to access to all dnd functions.

So seems to me the private library of nautilus is somehow an artificial
split, which provides more problems than solutions.

We needed libnautilus-private to have a private library that we could
isolate from extensions, but I don't think it worth given the problems
it provides, and also, this not so good logical split.
Right now, since with the desktop split we created a libnautilus to be
used by the desktop part of nautilus, extensions have access to all
the API of nautilus. We will think in future how this can be handled if
we want.

So for now, merge the libnautilus-private into src, and let's rethink
a better logic to split the code and the private parts of nautilus than
what we had.

Thanks a lot to Rafael Fonseca for helping in get this done.
Comment 2 Rafael Fonseca 2016-04-25 15:47:11 UTC
Review of attachment 326694 [details] [review]:

This patch removes the cyclic libnautilus-private -> src -> libnautilus-private dependency and it is a necessary step towards cleaning and restructuring the src folder.

Compilation and distcheck work successfully.

r+ from me.
Comment 3 Carlos Soriano 2016-04-25 15:58:44 UTC
Cool, thanks a lot Rafael!
Comment 4 Carlos Soriano 2016-04-25 15:59:34 UTC
Attachment 326694 [details] pushed as 7e24f1b - general: merge libnautilus-private to src