GNOME Bugzilla – Bug 765532
Ctrl-X (Cut) is missing from keyboard shortcuts
Last modified: 2016-06-20 13:44:56 UTC
Created attachment 326681 [details] no cut shortcut Hi, nautilus/src/resources/gtk/help-overlay.ui doesn't list the Ctrl+X (cut) shortcut. pls see attach. thanks regards Pedro Beja
Created attachment 326803 [details] [review] add missing cut shortcut to the list
Review of attachment 326803 [details] [review]: Hi, Pedro, thanks for your patch! The changes themselves look good to me, however, there is no commit message. A commit message is very useful in that it communicates the changes to other developers without needing to peruse them. We have guidelines for writing one, as well: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines Sorry for the long wait!
Comment on attachment 326803 [details] [review] add missing cut shortcut to the list From 20ea6d6a232028d3a1b5622fd1f499f5e324cedf Mon Sep 17 00:00:00 2001 From: Pedro Beja <althaser@gmail.com> Date: Fri, 27 May 2016 21:41:27 +0100 Subject: [PATCH 1/1] add a forgotten cut shortcut --- src/resources/gtk/help-overlay.ui | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/resources/gtk/help-overlay.ui b/src/resources/gtk/help-overlay.ui index a29fadb..1ef043a 100644 --- a/src/resources/gtk/help-overlay.ui +++ b/src/resources/gtk/help-overlay.ui @@ -324,6 +324,13 @@ <child> <object class="GtkShortcutsShortcut"> <property name="visible">True</property> + <property name="title" translatable="yes" context="shortcut window">Cut</property> + <property name="accelerator"><Primary>X</property> + </object> + </child> + <child> + <object class="GtkShortcutsShortcut"> + <property name="visible">True</property> <property name="title" translatable="yes" context="shortcut window">Copy</property> <property name="accelerator"><Primary>C</property> </object> -- 2.8.1
Hey Pedro, Seems you didn't update the patch, or at least the commit message is still missing. Also remember to use the format: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines Thanks!
Created attachment 328726 [details] [review] add missing cut shortcut to keyboard shortcut list
Hey Carlos, thanks for your reply. Well I attached a newer patch with commit message already. thanks :) regards Pedro
Review of attachment 328726 [details] [review]: This is better, but not quite yet what we are looking for. In the subject line, you should add the “component” that the commit is against (e.g. “help-overlay: add missing shortcut for cut”). The body should consist of briefly explaining the problem and what has been done to fix it. Consider something like “The shortcut for ‘cut’ was missing from the shortcut list. This commit adds it.”.
Created attachment 329424 [details] [review] add missing shortcut for cut thanks Ernestas
Review of attachment 329424 [details] [review]: Okay, it’s fine if you want to use my examples, but one last thing. What I meant was replacing the subject line >nautilus: add missing shortcut for cut with >help-overlay: add missing shortcut for cut
Created attachment 329955 [details] [review] help-overlay: add missing shortcut for cut
Attachment 329955 [details] pushed as efacc0a - help-overlay: add missing shortcut for cut
Thanks, Pedro, and sorry for being so hard. Hope to see more of your contributions!