After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765531 - Review UI shows for all application types, regardless if the review server can review them
Review UI shows for all application types, regardless if the review server ca...
Status: RESOLVED WONTFIX
Product: gnome-software
Classification: Applications
Component: General
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-04-25 11:42 UTC by Robert Ancell
Modified: 2016-07-07 03:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Robert Ancell 2016-04-25 11:42:32 UTC 
If a plugin provides review support then review UI is shown for all applications. A review server might only be able to review certain application types (e.g. PackageKit apps, not XDG apps).

Proposed solution is to have a new flag that is set in refine "reviewable". Then each plugin can determine which apps they can review.
Comment 1 Richard Hughes 2016-04-26 11:12:28 UTC 
Isn't this just AS_APP_QUIRK_NOT_REVIEWABLE?
Comment 2 Robert Ancell 2016-04-26 12:17:50 UTC 
As I understand it AS_APP_QUIRK_NOT_REVIEWABLE is for things that are fundamentally unreviewable (i.e. not an app as such).

This proposal is mark which apps can be reviewed when they are refined (i.e. there is a review plugin that can review this app type). The specific case was the Ubuntu store which can only review .deb packages (i.e. not XDG apps / snaps).

We discussed this before I went on leave and I was meant to file this bug then...
Comment 3 Richard Hughes 2016-04-27 18:39:05 UTC 
So the problem with this opt-in approach is that other plugins are then unable to handle the review action. There's nothing wrong in theory using the ODRS anon server for snappy apps and the ubuntu review server for .debs...
Comment 4 Robert Ancell 2016-07-07 03:37:01 UTC 
AS_APP_QUIRK_NOT_REVIEWABLE is working well enough for now so I don't need this feature.