After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765496 - Clean up gtklabel.c a bit
Clean up gtklabel.c a bit
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkLabel
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-04-24 10:58 UTC by Timm Bäder
Modified: 2016-04-26 00:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use g_list_nth_data instead of manually iterating of the links GList (2.51 KB, patch)
2016-04-24 10:58 UTC, Timm Bäder
accepted-commit_now Details | Review
Use g_clear_object (1.23 KB, patch)
2016-04-24 10:59 UTC, Timm Bäder
committed Details | Review

Description Timm Bäder 2016-04-24 10:58:43 UTC
Created attachment 326630 [details] [review]
Use g_list_nth_data instead of manually iterating of the links GList

It's already long enough as it is, so try to save a few LOC.
Comment 1 Timm Bäder 2016-04-24 10:59:12 UTC
Created attachment 326631 [details] [review]
Use g_clear_object
Comment 2 Matthias Clasen 2016-04-25 02:43:15 UTC
Review of attachment 326630 [details] [review]:

sure
Comment 3 Matthias Clasen 2016-04-25 02:43:52 UTC
Review of attachment 326631 [details] [review]:

ok