After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765495 - meson.lang: add 'elif' keyword and 'library' built-in function
meson.lang: add 'elif' keyword and 'library' built-in function
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: Syntax files
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-24 10:50 UTC by Tim-Philipp Müller
Modified: 2016-04-24 17:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson.lang: add 'elif' keyword and 'library' built-in function (1.00 KB, patch)
2016-04-24 10:50 UTC, Tim-Philipp Müller
committed Details | Review

Description Tim-Philipp Müller 2016-04-24 10:50:36 UTC
Created attachment 326629 [details] [review]
meson.lang: add 'elif' keyword and 'library' built-in function

Add two more highlights for the meson build system syntax specification.

Unrelatedly: For some reason comments (anything after a '#') are not properly syntax-highlighted anymore, I *think* this used to work.
Comment 1 Paolo Borelli 2016-04-24 15:50:56 UTC
Review of attachment 326629 [details] [review]:

Sure. both on master and 3-20
Comment 2 Paolo Borelli 2016-04-24 15:54:06 UTC
I do not see a comment context in the lang file at all. Maybe before it was just detected as python or some other language because there was no lang file?

Adding a comment context should be trivial: just add

        <context ref="def:shell-like-comment"/>

to the main context
Comment 3 Paolo Borelli 2016-04-24 15:54:32 UTC
(if you test that and it works, go ahead and push it)
Comment 4 Tim-Philipp Müller 2016-04-24 17:16:14 UTC
Thanks, that works!

Pushed to master and 3.20:

commit 8eff0d8c6c7461f66268a342e5ed3648001fffab
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sun Apr 24 18:14:33 2016 +0100

    meson.lang: fix comments
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765495

commit f3df770151d482d57046c533d821d3b6cfcf4414
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sun Apr 24 11:45:57 2016 +0100

    meson.lang: add 'elif' keyword and 'library' built-in function
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765495