After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765487 - [PATCH] gnome-session-check-accelerated-gl-helper --help shows translated characters as question marks on some locales
[PATCH] gnome-session-check-accelerated-gl-helper --help shows translated cha...
Product: gnome-session
Classification: Core
Component: general
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Reported: 2016-04-24 04:49 UTC by Ting-Wei Lan
Modified: 2016-05-09 19:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

tools: Call setlocale in gl-helper and gles-helper (1.88 KB, patch)
2016-04-24 04:50 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2016-04-24 04:49:39 UTC
Please see the attached patch for gnome-session-check-accelerated-gl-helper and gnome-session-check-accelerated-gles-helper. The translated messages can be broken if setlocale is not called.

Running 'gnome-session-check-accelerated-gl-helper --help' with zh_TW.UTF-8 locale shows:
  gnome-session-check-accelerated-gl-helper [???]

  -h, --help               ???????

  -p, --print-renderer     Print GL renderer name

Although it is not required for gnome-session-check-accelerated-gles-helper to manually call setlocale because GTK+ does it automatically, I still modify it to keep the two helpers similar.
Comment 1 Ting-Wei Lan 2016-04-24 04:50:28 UTC
Created attachment 326617 [details] [review]
tools: Call setlocale in gl-helper and gles-helper

It is required to correctly show translated messages on some locales.
Comment 2 Michael Catanzaro 2016-05-09 19:22:29 UTC
Attachment 326617 [details] pushed as 7198a55 - tools: Call setlocale in gl-helper and gles-helper