This is on purpose from GVFS. I also wonder whether is a good idea or not, so worth discussing.

Hmm, I can't reproduce it on Fedora, could you please provide outputs from "gvfs-mount -li" before and after the reboot with the connected flash drive?

I suppose "internal drives" are not shown in the sidebar by default. Carlos, am I correct? So I suppose there is a problem with detection whether it is "internal drive" or "removable drive". Carlos, what needs to be set for the mount to be shown in the sidebar?

hey, yeah you are correct Ondrej.

This is the code, if this returns true it's shown in the sidebar: https://git.gnome.org/browse/gtk+/tree/gtk/gtkplacessidebar.c#n867

and I believe the problem is maybe around https://git.gnome.org/browse/gvfs/tree/monitor/udisks2/gvfsudisks2drive.c#n239 ?

Okay here is the output of "gvfs-mount -li" (I've only kept the concerned disk):
 - Before reboot: http://pastebin.com/M5Ra1TWw
 - After reboot: http://pastebin.com/82X75xHu
 - The diff between the two: http://pastebin.com/DeJH38TG
So the difference is "can_stop".

(In reply to Quentin Marlats from comment #4)
> Okay here is the output of "gvfs-mount -li" (I've only kept the concerned
> disk):
>  - Before reboot: http://pastebin.com/M5Ra1TWw
>  - After reboot: http://pastebin.com/82X75xHu
>  - The diff between the two: http://pastebin.com/DeJH38TG
> So the difference is "can_stop".

Thanks for the info. So seems the issue is the one pointed out in comment #3.

You are right, but don't know what we can do with it. AFAIK there isn't any reliable way how to determine whether the device is internal/external. The heuristic used in the code expects that external devices are plugged in during the session, which obviously fails in this case...

Designers wanted to hide internal devices by default to reduce the number of entries in the sidebar. I think it is ok to hide also e.g. external disks if they are always connected though it is a bit confusing. 

I don't see the bug with my flash drive because it is ejectable. So this is basically udisks2 bug, however there is also a note in the udisks2 documentation that this is only a guess:
https://udisks.freedesktop.org/docs/latest/gdbus-org.freedesktop.UDisks2.Drive.html#gdbus-property-org-freedesktop-UDisks2-Drive.Ejectable

Carlos, do you have some idea? I would close this as WONTFIX.

> Carlos, do you have some idea? I would close this as WONTFIX.

I agree with you, is udisk2 bug. So instead of a WONTFIX, I guess it's NOTGNOME, and would be good to fix it on udisk2.

I agree we cannot rely on can_stop for can_eject not being good enough... Probably I should remove that can_stop check in the sidebar. But I added it because the can_eject was failing most of the times and users reported that most of the ejectable drives were on the other-locations :/

I found Removable property, which might be useful (we don't use it in gvfs currently):
https://udisks.freedesktop.org/docs/latest/gdbus-org.freedesktop.UDisks2.Drive.html#gdbus-property-org-freedesktop-UDisks2-Drive.Removable

Quentin, could you please provide output from "udisksctl dump" before and after reboot as you did with "gvfs-mount -li" please? I wonder what is value of "Removable" property in such cases, but I afraid it corresponds with "Ejectable".

It seems that udisks2 more or less reflects /sys/block/sdb/removable, so it is rather kernel bug...

Yep:
 - Before reboot: http://pastebin.com/qnaSW0JK
 - After reboot: http://pastebin.com/3KG8B7V5
 - The diff: http://pastebin.com/fTRZHJJ0
It seems that UDisks2 detects the flash drive as removable after reboot. :-)

(In reply to Quentin Marlats from comment #9)
> Yep:
>  - Before reboot: http://pastebin.com/qnaSW0JK
>  - After reboot: http://pastebin.com/3KG8B7V5
>  - The diff: http://pastebin.com/fTRZHJJ0
> It seems that UDisks2 detects the flash drive as removable after reboot. :-)

That's really good news. Could we get a confirmation from udisk2 devs Ondrej?

Thanks for the logs. So maybe we can add g_drive_is_removable to propagate this flag, which can be used to determine internal/external drives. I will try to get some feedback from udisks guys...

Hmm Removable is FALSE for my internal disk and it is TRUE (even after restart) for internal/external optical mechanics, flash drive, card reader, so it seems to be usable for our purpose...

Removable is TRUE for drives on usb/sdio/ieee1394 buses, see:
https://cgit.freedesktop.org/udisks/tree/src/udiskslinuxdrive.c#n875

It should work as we intended according to Peter Hatina from storaged.

Created attachment 327141 [details] [review]
monitor: Add g_drive_is_removable() support

Nautilus wants to show entries in the sidebar only for removable devices. It uses currently sort of conditions to determine which devices should be shown. Those condition fails in some cases unfortunatelly. Lets provide g_drive_is_removable() which uses udisks Removable property to determine which devices should be shown. It should return true for all drives with removable media, or flash media, or drives on usb and firewire buses.

Add support for this property also in gvfs-mount tool.

Bump GLib version accordingly.

Created attachment 327567 [details] [review]
monitor: Add g_drive_is_removable() support

Removed redundant variable...

Review of attachment 327567 [details] [review]:

::: monitor/proxy/gproxydrive.c
@@ +246,3 @@
+  while (g_variant_iter_loop (iter_expansion, "{sv}", &key, &value))
+    {
+      if (!g_strcmp0 (key, "is-removable"))

Please, use `g_str_equal (key, "is-removable")`. It's a lot more readable, and keys in a {sv} cannot be NULL — at most they are empty strings.

Created attachment 327716 [details] [review]
monitor: Add g_drive_is_removable() support

Thanks for the review!

Review of attachment 327716 [details] [review]:

Looks good to me, but I'm not the GVFS maintainer, so I'll just put the 'reviewed' status and a +1 for pushing it to master.

Comment on attachment 327716 [details] [review]
monitor: Add g_drive_is_removable() support

commit b798655