After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765453 - Patch to stop "Unhandled action type" warnings spam in logs from custom atoms
Patch to stop "Unhandled action type" warnings spam in logs from custom atoms
Status: RESOLVED FIXED
Product: libwnck
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: libwnck maintainers
libwnck maintainers
: 765452 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-04-23 02:48 UTC by orbit
Modified: 2016-04-25 14:26 UTC
See Also:
GNOME target: ---
GNOME version: 3.17/3.18

Attachments
Warning fix (503 bytes, patch)
2016-04-23 02:48 UTC, orbit 		rejected Details | Review

Description orbit 2016-04-23 02:48:06 UTC 
Created attachment 326587 [details] [review]
Warning fix

libwnck is flooding systemd journal very hard with "Unhandled action type" warnings when it encounters atom that it doesn't understand. Openbox being a particular victim of this spam because it employs custom atom _OB_WM_ACTION_UNDECORATE for its needs.

Attached patch changes the behavior of this warning to occur only when unknown atom's name is null or begins with "_NET_WM_" in its name, thereby suppressing warnings for all non-standard atoms.
Comment 1 orbit 2016-04-23 02:53:33 UTC 
*** Bug 765452 has been marked as a duplicate of this bug. ***
Comment 2 Marco Trevisan (Treviño) 2016-04-25 14:24:50 UTC 
Review of attachment 326587 [details] [review]:

The patch is against the .orig, file.
Also, you could just have called g_str_has_prefix.

I've fixed the patch and pushed upstream BTW. Thanks for pointing out the issue.